Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Use build_requires in setup.cfg #20

Merged
merged 1 commit into from
Nov 15, 2021

Conversation

matthewfeickert
Copy link
Contributor

@matthewfeickert matthewfeickert commented Nov 15, 2021

In the sdist creation phase of the build there is currently the warning:

$ python setup.py sdist
/home/runner/work/panda-client/panda-client/setup.py:6: DeprecationWarning: The distutils package is deprecated and slated for removal in Python 3.12. Use setuptools or check PEP 632 for potential alternatives
  import distutils
/opt/hostedtoolcache/Python/3.10.0/x64/lib/python3.10/site-packages/setuptools/dist.py:697: UserWarning: Usage of dash-separated 'build-requires' will not be supported in future versions. Please use the underscore name 'build_requires' instead
  warnings.warn(
...

[bdist_rpm]
provides = panda-client
release = 1
packager = Panda Team <hn-atlas-panda-pathena@cern.ch>
build-requires = python-devel

This PR addresses the setuptools warning RE: using build_requires in setup.cfg.

The distuitls warning should be addressed in a separate PR.

Addresses warning in sdist build:
> UserWarning: Usage of dash-separated 'build-requires' will not be
> supported in future versions. Please use the underscore name
> 'build_requires' instead
@matthewfeickert
Copy link
Contributor Author

@tmaeno this is ready for review. Please let me know if you have any questions.

@tmaeno tmaeno merged commit 076793e into PanDAWMS:master Nov 15, 2021
@matthewfeickert matthewfeickert deleted the fix/use-build_requires branch November 15, 2021 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants