Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release Version Naming #92

Closed
ianhattendorf opened this issue May 9, 2018 · 4 comments
Closed

Release Version Naming #92

ianhattendorf opened this issue May 9, 2018 · 4 comments

Comments

@ianhattendorf
Copy link

Would it be possible to modify the release naming template going forward? Hyphens are incompatible with rpms/debs. Maybe something like 2.11.c instead of 2.11-c?

@PandorasFox
Copy link

Hm, sounds reasonable. The next release I make (there might be a point release in the next couple weeks) will probably be like 2.11.c or 2.11.c.1 - I'm still unsure if I want to keep to the same major version # that upstream uses, or if I want to just break off.

(I'll keep this open until my next release so I don't forget)

@ianhattendorf
Copy link
Author

Sounds like a plan, thanks. I would say if you do a point release then go with 2.11.c.1 to avoid repeating a version. Basically, you just never want to go backwards or have a duplicate version.

Tracking upstream's version is definitely helpful, but depending on how much changes it may start to lose its meaning so I can see either way there.

@PandorasFox
Copy link

Yeah, definitely. I've been super on the fence about keeping the version numbers in-line with upstream - on the one hand, it's handy to tell if I've merged upstream's latest stuff yet, but on the other hand, it becomes kinda a pain to make i3lock-color releases that aren't related to upstream releases (and I want to avoid future naming conflicts, so just appending a -c seemed the easiest at the time... oops)

Synthetica9 added a commit to Synthetica9/nixpkgs that referenced this issue Oct 2, 2018
Note the change in naming scheme, this is intentional
(Raymo111/i3lock-color#92)
xeji pushed a commit to NixOS/nixpkgs that referenced this issue Oct 2, 2018
Note the change in naming scheme, this is intentional
(Raymo111/i3lock-color#92)
@PandorasFox
Copy link

Fixed in the latest release. Sorry about the delay in release; my internship this summer kept me tired & busy.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants