Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ListRepresenter, Representer and ArrayRepresenter should be in same file #8

Open
driescroons opened this issue Mar 16, 2022 · 3 comments

Comments

@driescroons
Copy link

I feel like we should the representers in 1 single file with different exports. They're small files, so why not?

@ljobse
Copy link
Member

ljobse commented Mar 17, 2022

What's the benefit?

@driescroons
Copy link
Author

cleanup

@ljobse
Copy link
Member

ljobse commented Mar 18, 2022

Goes against the general naming conventions I'd say. Usually I'm not a fan of having multiple things in one file. It would add the "complexity" of always having to choose if things should be combined or not, naming can become unclear, locating certain things can become more difficult.

In some cases I agree it would make sense to group items but it doesn't way up to the downsides. So I rather keep it consistent

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants