Shadow bias seam #148
Merged
Shadow bias seam #148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Recently, I made several improvements to shadow mapping. During testing, I didn’t notice the seam in the Bistro world. The shadow maps have fixed and slope-based bias baked into them anyway, which significantly reduces shadow acne. Given this, we can remove the constant bias. Thank you! 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR eliminates the constant used in the compute calculation of the world position with normal offset. Its presence was causing significant seams and lighting problems in shadow-mapping. I would appreciate it if you could clarify whether this constant is essential or if its inclusion was an oversight. Based on my tests, its absence does not appear to contribute to any shadow acne issues.