Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CI to our Pull Requests #77

Open
bcabio opened this issue Jun 19, 2017 · 2 comments
Open

Add CI to our Pull Requests #77

bcabio opened this issue Jun 19, 2017 · 2 comments

Comments

@bcabio
Copy link
Member

bcabio commented Jun 19, 2017

Would you guys @mhijazi1 @braxton-mclean @arshbot be for something like this? It'd be good just so when people submit a PR they get some immediate feedback on code rather than having to wait for you guys to review.

https://github.com/marketplace/travis-ci#pricing-and-setup

Maybe not this one specifically but something to this effect.

@mhijazi1
Copy link
Contributor

Adding CI into our build is a longterm goal we have, but to get to that we need people to start writing unit tests/integration tests as well. Since just having it build doesn't really work for our case. I'm gonna label this as a long term goal, since it requires our members/contributors to learn about unit/integration tests.

@mhijazi1
Copy link
Contributor

Also i'm gonna rename this issue to add CI to PRs as thats more accurate

@mhijazi1 mhijazi1 changed the title Have an extra layer of code review Add CI to our Pull Requests Jun 19, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants