Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct version and compatibility metadata #169

Closed
wants to merge 1 commit into from

Conversation

phardy
Copy link

@phardy phardy commented Apr 16, 2017

Sorry folks, I realise this probably isn't the best destination branch, but you didn't seem to have one for the 1.2.9 prereleases.

Current prereleases intended for KSP 1.2.9 include an AVC .version file that declares them as compatible with KSP 1.2.2. They also use exactly the same version as the stable KSP 1.2.2 release. These two facts will cause tools that rely on the .version file, such as AVC and the CKAN indexer, to give misleading and probably catastrophic results.

Pull request just updates the .version file to accurately reflect KSP compatibility, as well as bumps the build in the version number to indicate that it is actually a different build.

@DoctorDavinci
Copy link
Collaborator

CKAN and AVC give catastrophic results regardless of what is in the .version file

There was a build released that is compatible with 1.2.9 ... CKAN trying to force modders to do what they say is in bad form if you ask me

@gomker
Copy link
Collaborator

gomker commented Jun 9, 2017

Closing this as this was handled in other PR's

@gomker gomker closed this Jun 9, 2017
SuicidalInsanity pushed a commit to SuicidalInsanity/BDArmory that referenced this pull request May 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants