Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Loading invalid chunk crashes server instead of just throwing an exception #7

Closed
Malfrador opened this issue Mar 29, 2023 · 0 comments
Closed

Loading invalid chunk crashes server instead of just throwing an exception #7

Malfrador opened this issue Mar 29, 2023 · 0 comments
Labels
type: bug Something doesn't work as it was intended to. version: 1.19.4 Game version 1.19.4

Comments

@Malfrador
Copy link
Member

Malfrador commented Mar 29, 2023 •
edited

Loading Chunks with invalid data, for example heightmaps that don't match the world height, crashes a Folia server. On Paper, an exception is thrown and logged, but the server keeps running.

Steps to reproduce:

  1. Download the world: world.zip (Datapack is included).
  2. Run Folia with the world. Everything should work normally. The world height should be 512.
  3. Stop the server and delete the world_height.zip datapack. The world height is now vanilla.
  4. Start the Folia server and try to join it. The server will instantly stop with a Chunk system crash propagated from unrecoverableChunkSystemFailure error. https://pastes.dev/8xcPKOkrVT
  5. Now do the same with a Paper server. The following errors will be thrown, but the server will keep running: https://pastes.dev/POXbmGPMRf

Full Folia log: https://pastes.dev/z9x1hQM8Ax (relevant part should be above)

Im aware that this pretty cursed in general, but its a behaviour difference from Paper so I thought I report it.
@kashike kashike added type: bug Something doesn't work as it was intended to. version: 1.19 labels Mar 30, 2023
killerprojecte pushed a commit to killerprojecte/Folia that referenced this issue May 30, 2023
@Spottedleaf
Fix incorrect error handling in off-main chunk load task
b9459cb 
Now that there is no on-main task, the completion logic
for the status task is completed with the results passed
by the off-main task. Thus, the chunk system saw a non-null
throwable and assumed a fatal crash. The old on-main task
did not pass the throwable through in this case, which allowed
the chunk to re-generate.

Fixes PaperMC#7
killerprojecte referenced this issue in killerprojecte/Folia Jun 17, 2023
@sofianedjerbi
Merge pull request #7 from KaiijuMC/update-upstream
c06b0d7 
Update Upstream (Purpur)
@kashike kashike added version: 1.19.4 Game version 1.19.4 and removed version: 1.19 labels Apr 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type: bug Something doesn't work as it was intended to. version: 1.19.4 Game version 1.19.4
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kashike @Malfrador