Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hoppers unable to push into hopper minecarts in full block #5141

Closed
sethwheway opened this issue Jan 31, 2021 · 8 comments · Fixed by #7342
Closed

Hoppers unable to push into hopper minecarts in full block #5141

sethwheway opened this issue Jan 31, 2021 · 8 comments · Fixed by #7342
Labels
status: accepted Disputed bug is accepted as valid or Feature accepted as desired to be added. type: bug Something doesn't work as it was intended to. version: 1.18 Game version 1.18

Comments

@sethwheway
Copy link

What behaviour is expected:

Hoppers should be able to push items into hopper minecarts as long as they are in range (the vanilla behavior)

What behaviour is observed:

Hopper minecarts are unable to push items into hopper minecarts when the hopper minecart is in a full block (but can for air/transparent blocks)

Steps/models to reproduce:

image
If the pink concrete is replaced with a transparent block or removed, the hopper is able to push items

Plugin list:

Happens without plugins

Paper version:

This server is running Paper version git-Paper-457 (MC: 1.16.5) (Implementing API version 1.16.5-R0.1-SNAPSHOT)
(Latest)

Anything else:

I am unsure whether this is intentional or just an implementation detail of all the patches to hoppers and minecarts. Anyhow, it is non-vanilla behavior and I see no reason for it to be kept

@sethwheway
Copy link
Author

May be related to #4633

@Chew Chew added the type: bug Something doesn't work as it was intended to. label Jan 31, 2021
@Thibaut040
Copy link

I have the same issue. (Using: Paper version git-Paper-584 (MC: 1.16.5) (Implementing API version 1.16.5-R0.1-SNAPSHOT))

@Machine-Maker
Copy link
Member

I cannot replicate this on paper 1.18.1. I created the setup displayed, and a hopper from all sides could push into the hopper minecart inside the pink concrete powder block. If there are updated reproduction steps, this can be reopened.

@Machine-Maker Machine-Maker added the resolution: cannot reproduce Paper team is unable to replicate the issue. label Jan 14, 2022
@sethwheway
Copy link
Author

sethwheway commented Jan 14, 2022

I'm able to recreate this fine on a new 1.18.1 paper instance I just spun up. I'm not sure why you'd unable to replicate it.
https://user-images.githubusercontent.com/14334544/149523505-5525c924-0d66-4685-a291-de55e342cbb9.mp4
Let me know if there's anything I can do to help.

@Machine-Maker
Copy link
Member

Yeah, you’re right. I must’ve gotten turned around when I compared vanilla to paper server behavior and thought I had just tested on paper, when it was my vanilla testing server. Thanks for catching it.

@Machine-Maker Machine-Maker reopened this Jan 14, 2022
@Machine-Maker Machine-Maker added version: 1.18 Game version 1.18 and removed resolution: cannot reproduce Paper team is unable to replicate the issue. version: 1.16 Game version 1.16 labels Jan 14, 2022
@Machine-Maker
Copy link
Member

So the fix for this right how, is to set hopper.ignore-occluding-blocks in paper.yml to false. I am, however, of the opinion that this should be the default setting to preserve behavior so I think this issue can stay open until that question is resolved.

@Machine-Maker Machine-Maker added the status: accepted Disputed bug is accepted as valid or Feature accepted as desired to be added. label Jan 14, 2022
@sethwheway
Copy link
Author

Thank you for the calrification. I see now there is an option to enable this behaviour in 3a43821.
I agree that it should probably be set true by default for parity with vanilla behaviour. Would you like me to update the title of this issue?

@Machine-Maker
Copy link
Member

Yeah, edit the original post to reflect that you think the default value should be changed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: accepted Disputed bug is accepted as valid or Feature accepted as desired to be added. type: bug Something doesn't work as it was intended to. version: 1.18 Game version 1.18
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants