Add entity heal API #10267
Merged
Add entity heal API #10267
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I've added the missing annotations required by the tests. However after some discussion on Discord I believe the healing either needs to happen without calling an event or there needs to be some sort of flag to control whether or not the EntityRegainHealthEvent is called. |
notTamion
suggested changes
Feb 24, 2024
kennytv
approved these changes
May 30, 2024
Machine-Maker
force-pushed
the
entity-heal-api
branch
from
4eff4a6
to
5228203
Compare
lynxplay
approved these changes
May 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I haven't contributed to Paper yet so I'm not sure if this is all correct. I feel like this is useful since healing an entity is a pretty common use case and there already is a heal method in NMS.