disguise api #10478
Open
disguise api #10478
+121,473
−114,885
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yannicklamprecht
force-pushed
the
feature/disguise-api
branch
4 times, most recently
from
ce89b24
to
9c2de57
Compare
kashike
requested changes
Apr 29, 2024
yannicklamprecht
force-pushed
the
feature/disguise-api
branch
from
9c2de57
to
c37d61b
Compare
yannicklamprecht
force-pushed
the
feature/disguise-api
branch
11 times, most recently
from
0271101
to
d38b35d
Compare
MiniDigger
reviewed
May 4, 2024
MiniDigger
reviewed
May 4, 2024
MiniDigger
reviewed
May 4, 2024
yannicklamprecht
force-pushed
the
feature/disguise-api
branch
4 times, most recently
from
cf41890
to
9d0fd05
Compare
The player sample uses game profile internally, but discards everything but the name and uuid and does not follow player profile restrictions, so it doesn't make sense to use that in the event.
Upstream has released updates that appear to apply and compile correctly. This update has not been tested by PaperMC and as with ANY update, please do your own testing Bukkit Changes: befcf86d SPIGOT-7740: Fix using new map cursor types 09229095 Add EntityDamageEvent.DamageCause#CAMPFIRE CraftBukkit Changes: a1d2cd152 SPIGOT-7747: Mob head is not dropped when mob was blown up by a charged creeper 8078294bc SPIGOT-7746: Server Crashing when Players Getting into End Portals 8d842e250 SPIGOT-7744: Fix exception for shooting projectiles with flame enchantment 64e0ad129 SPIGOT-7744: Fix crash when shooting arrows in creative mode 819f7a10a Fix player items not dropping on death 0a0229bb5 Implement DamageCause#CAMPFIRE and minor improvement in exception for Unhandled block damage
Mostly for the primitive long to reference hashtable impl
yannicklamprecht
force-pushed
the
feature/disguise-api
branch
from
e07edba
to
310363d
Compare
|
Update to 1.21. Now we need to wait until dev/1.21 is merged into master. |
and generate maps to allow entity metadata syncher validation
yannicklamprecht
force-pushed
the
feature/disguise-api
branch
from
310363d
to
db64d58
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
relates to #10584
Adds a simple disguise api that also makes sure that invalid entity data, not belonging to the type that is faked, is filtered.
It also adds a server generator module to reduce maintenance of the entity data filter.
tldr; The API provides a way to disguise any entity as another or a player with having the possibility to interact with the entity like with any others. The big advantage is that you've the whole vanilla logic and Mob Goal and Pathfinding included without hassle.
Testing the changes can be done using the following snippet:
https://gist.github.com/yannicklamprecht/639acba127a54f5617e1281f099b7aff
TODO:
figure out how to get teams working with real teams, client side ones worked in my forkNon issue just use theEntity#getName()instead of theEntity#getScoreboardEntryName()Effective loc: