Add EntityKnockbackByEntityEvent #1162
Conversation
There was a problem hiding this comment.
I think this approach is fine, but it is different than how I did my own event:
https://github.com/starlis/empirecraft/blob/master/patches/server/0032-EntityKnockbackEvent.patch
I did it at obtaining the knockback level.
But this also accounts for explosions which is good. I can prob drop my own for how i use it and rework my code around this.
But all I can mainly see is desire to change entity and override getEntity() to be LivingEntity
| + private final Vector acceleration; | ||
| + private boolean cancelled = false; | ||
| + | ||
| + public EntityKnockbackByEntityEvent(Entity entity, Entity hitBy, Vector acceleration) { |
There was a problem hiding this comment.
I don't think a non living entity can be hit by knockback, since the impl is in EntityLiving...
entity should be LivingEntity.
I wish hitBy also was, but this also fires for explosions too, so Entity is valid there.
Brokkonaut
force-pushed
the
feature-entityknockbackevent
branch
from
9fa2ede
to
996a9ec
Compare
|
Ok, I changed the Entity to LivingEntity |
This event is called when an entity receives knockback by another entity. The knockback acceleration can be modified in the event. If the event is cancelled the entity is not knocked back at all.
Brokkonaut
force-pushed
the
feature-entityknockbackevent
branch
from
996a9ec
to
61dd628
Compare
This event is called when an entity receives knockback by another entity. The knockback can be modified in the event. If the event is cancelled the entity is not knocked back.