Re-Add Anti-Xray

[Spottedleaf]

mode 2 as an example

[Gerrygames]

I did upload this to our servers and it seems to be working fine so far. 👍

[rbreslow]

This seems like an overkill patch to add to Paper core. Do you think you could resubmit split up or at least add some documentation or more context as to what this PR is changing?

[kickash32]

This seems like an overkill patch to add to Paper core. Do you think you could resubmit split up or at least add some documentation or more context as to what this PR is changing?

This patch was already in paper perviously, documentation is in here https://paper.readthedocs.io/en/stable/server/configuration.html

[MiniDigger]

@rbreslow you are prolly looking at the diff of the patch file, which is kinda hard to read if you don't know the full patch. if you are just interested in watch this patch does (and not in the changes for 1.14), look here
https://github.com/Spottedleaf/Concrete-PR/blob/anti-xray/Spigot-Server-Patches/0408-Anti-Xray.patch

[Gerrygames]

One of our servers crashed today. Looks like it might have something to do with the anti xray patch. We did not have this issue once before. I wasn't running the latest version though. I guess the newest commit could have fixed that issue? I'm currently building the newest versions and will test it on our servers.
Crash log:
https://hastebin.com/zopefogopi.md

[Spottedleaf]

yeah that's an xray issue

[rbreslow]

Seems like this would be something more suited to an add-on or an addition to NCP than as a big patch for Spigot. Isn't the goal of this project to mirror the vanilla server just with higher performance? Not to add new behavior like this?

Was there a reason it was originally removed, as it seems like that's what happened?

[kickash32]

Anti-Xray is a configurable feature and is disabled by default, reason it was removed was because it needed to be updated.

[Gerrygames]

After updating to the latest versions the servers started to crash more often. Hastebin seems to be down so I can't take a look at the previous crash log but maybe this one is different.
http://paste.cytooxien.de/ruriharawo.md

[Spottedleaf]

yeah that was an oversight in a recent change; I should have accounted for plugin-sent packets

As for the first crash can you show more logs?

[Gerrygames]

Yeah that was our replay system writing chunks to the replay.
One server crashed this morning but it was restarted before I copied the log. I configured the server so that the logs won't be deleted and will send you the log as soon as another crash occurs.

[Gerrygames]

Here's another crash log:
http://paste.cytooxien.de/demulifezu.md

[Spottedleaf]

please try again on latest, it should be resolved now

[Gerrygames]

Okay. Uploaded and running. I will inform you about any crashes.

[Gerrygames]

No crashes so far 👍

[Gerrygames]

Unfortunately a server crashed again:
http://paste.cytooxien.de/acaretiqot.md

[Spottedleaf]

can you show the full log?

[Gerrygames]

Sure:
http://paste.cytooxien.de/oxuvahabev.md

[Spottedleaf]

Try again on latest, this one should be resolved now

[zachbr]

Updated paper jar for testing. Based on build 121 (dafc3db).
Please report bugs with the antixray system to this thread directly. You may be turned away for reporting them to the normal channels.

https://keybase.pub/zachbr/paper/github/pulls/2240/paperclip-121-GH2240-e679a7c.jar
md5sum: 7331d1e190b300c55b5f72fd9e6ba713
sha256sum: f0c3c6f68e32b6d2d75eb5e7a93ab9083da36e8a79d34b5fd471bafee57f0ac6

[Gerrygames]

No crashes since we uploaded version e679a7c 4 days ago.

[maxspeed3006]

No crashes since we uploaded version e679a7c 4 days ago.

Same, been running this for 6 days with no crashes so far with around 20 players.

[BillyGalbreath]

Little birdie told me more comments are wanted on this, so here's mine:

Been using it for over 3 weeks. Works great. ^_^

resolved

[kashike]