fix: origin world can be unknown while knowing location #5793
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Plz store the uuid in a field to keep even if the world is poof |
We will now store the world ID. It may not be used if the entity is loaded before the world in question is, but it might be used later on, should the entity come after the world. Signed-off-by: Mariell Hoversholm <proximyst@proximyst.com>
Proximyst
force-pushed
the
fix-origin-world-npe
branch
from
f41b320
to
029a486
Compare
9 tasks
|
how to solve the problem in the end? |
|
Update |
Merged
|
This was replaced by #5846 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If there is no world anymore (e.g. deleting the world an entity was
spawned in), it will be nulled while the location is still technically
legal.
I'm unsure whether this should rather keep the UUID in memory,
as that would be a very acceptable fix and would even retain the
origin world in these cases. That being said, it would be useless
information.
Fixes #5791.