Make tag presets unmodifiable #7378
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Machine-Maker
force-pushed
the
fix/modifiable-tags
branch
2 times, most recently
from
0a7480f
to
e2708e0
Compare
|
ensure size is a validation check, not a "last function" type call, really should just use an explicit lock call rather than hijacking ensureSize, imho |
|
It’s not hijacking it, it’s a whole other method. Default is that the existing ensureSize won’t lock it. |
|
you're adding a param onto a method which does 1 thing to make it do another behind the context of a boolean, I don't feel that locking should be part of the ensureSize method |
Machine-Maker
force-pushed
the
fix/modifiable-tags
branch
from
e2708e0
to
b3edd14
Compare
|
Ok, changed it to just use the |
electronicboy
approved these changes
Jan 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tag presets that Paper adds should not be modifiable as they are global which can lead to unexpected behavior.
If this breaks any behavior for plugins, its bad behavior. Tags are not locked by default, so no proper behavior with custom tags plugins add should be affected.