Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bedrock pattern fix #8474

Merged
merged 2 commits into from Oct 15, 2022
Merged

Bedrock pattern fix #8474

merged 2 commits into from Oct 15, 2022

Conversation

19MisterX98
Copy link
Contributor

image
image

Paper uses a fixed number for bedrock in the same column.
Vanilla uses the y coord of the bedrock block.

@19MisterX98 19MisterX98 requested a review from a team as a code owner October 15, 2022 19:59
@Machine-Maker
Copy link
Member

Yep, this was incorrectly copied. Another casualty of the decompiler using the same variable names. If you look at SurfaceRules$VerticalGradientConditionSource#apply$VerticalGradientCondition you can see there are two variables named i`. Looks like it was copied incorrectly and the slight difference in bedrock formations wasn't noticed.

@kennytv kennytv merged commit 603df98 into PaperMC:master Oct 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Machine-Maker Machine-Maker Machine-Maker approved these changes

@kennytv kennytv kennytv approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@19MisterX98 @Machine-Maker @kennytv