Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix plugin bootstrap dependency tree population #9963

Merged
merged 5 commits into from
Nov 25, 2023

Conversation

oxkitsune
Copy link
Contributor

@oxkitsune oxkitsune commented Nov 22, 2023

This patch fixes a bug where the dependency tree used for classpath joining,
wasn't built using the bootstrap dependencies, for plugin bootstrappers.


Download the paperclip jar for this pull request: paper-9963.zip

@Owen1212055 Owen1212055 marked this pull request as ready for review November 22, 2023 23:18
@Owen1212055 Owen1212055 requested a review from a team as a code owner November 22, 2023 23:18
@Owen1212055 Owen1212055 added the build-pr-jar Enables a workflow to build Paperclip jars on the pull request. label Nov 22, 2023
Copy link
Member

@Owen1212055 Owen1212055 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review looks good to me, will need to fixup original paper plugin patch on merge.

Tested using Paper's internal paper plugin tester tool.

@Owen1212055 Owen1212055 merged commit f9938d3 into PaperMC:master Nov 25, 2023
1 check passed
@oxkitsune oxkitsune deleted the gdejong/fix-plugin-bootstrap branch January 12, 2024 23:32
lynxplay pushed a commit to lynxplay/paper that referenced this pull request Feb 23, 2024
This patch fixes a bug where the dependency tree used for classpath joining,
wasn't built using the bootstrap dependencies, for plugin bootstrappers.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build-pr-jar Enables a workflow to build Paperclip jars on the pull request.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants