Add PlayerProfile support to PaperLib #4
Conversation
egg82
changed the title
| @@ -147,6 +149,36 @@ public static BlockStateSnapshotResult getBlockState(@Nonnull Block block, boole | |||
| return ENVIRONMENT.getBlockState(block, useSnapshot); | |||
| } | |||
|
|
|||
| /** | |||
There was a problem hiding this comment.
These API's weren't added to be async. They were added to more efficiently look up a players UUID than loading the entire offline player.
Nothing would prevent you loading the offline player async too, but I'm not sure this lib needs to handle that.
Lets just drop the async and keep them sync, and plugins can call the method async themselves.
There was a problem hiding this comment.
Hmm, fair. I guess I was just kinda going based off the current naming scheme. Though you can totally load them async it's not necessarily a requirement.
There was a problem hiding this comment.
You only changed the name. Need to remove the futures themselves and the async part too.
| @@ -147,6 +149,36 @@ public static BlockStateSnapshotResult getBlockState(@Nonnull Block block, boole | |||
| return ENVIRONMENT.getBlockState(block, useSnapshot); | |||
| } | |||
|
|
|||
| /** | |||
There was a problem hiding this comment.
You only changed the name. Need to remove the futures themselves and the async part too.
|
Closed in favor of #16 |
This adds PlayerProfile/UUID fetching support. Not much else to say, really.