Skip to content
This repository has been archived by the owner on Mar 8, 2024. It is now read-only.

Hostile mobs fail to spawn in the end dimension on 1.18 #99

Closed
Wesley1808 opened this issue Nov 29, 2021 · 3 comments
Closed

Hostile mobs fail to spawn in the end dimension on 1.18 #99

Wesley1808 opened this issue Nov 29, 2021 · 3 comments
Assignees
Labels
bug Something isn't working

Comments

@Wesley1808
Copy link

Since commit 440547d, enderman have not been able to spawn in the end dimension.
I have tested this on newer commits aswell, but that doesn't change anything.

The end world was also tested when completely regenerated, without any other mods installed - and reverting to an older commit afterwards seems to fix the issue aswell.

@Helinos
Copy link

Helinos commented Dec 6, 2021

I've been able to reproduce this issue.

@Helinos
Copy link

Helinos commented Dec 7, 2021

This issue seems to because caused by the new get RawBrightness method that was added/moved to this class in the commit. This method changed where it got the sky light value from, that being getSkyLightValue() as apposed to where it used to get it: skyReader.getLightValue().
This change causes this issue because getting the skylight value from the former method has no check for whether the dimension actually has a skylight, where the latter method does. This causes The End to have a sky light of 15 and subsequently prevent endermen from spawning, as they can only spawn in a light level below 12 or whatever.

I reverted this change in my fork and it seems to fix it.

@Spottedleaf Spottedleaf added the bug Something isn't working label Dec 8, 2021
@Spottedleaf Spottedleaf self-assigned this Dec 8, 2021
@Spottedleaf
Copy link
Member

e9ff6b7

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants