Create a new HttpClient per connection #1243
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
astei
reviewed
Feb 13, 2024
proxy/src/main/java/com/velocitypowered/proxy/network/ConnectionManager.java
Outdated
Show resolved
Hide resolved
If the instance is using Java 21, the HttpClient resources will be cleaned using its AutoCloseable interface
4drian3d
changed the title
kashike
requested changes
Feb 14, 2024
proxy/src/main/java/com/velocitypowered/proxy/network/ConnectionManager.java
Outdated
Show resolved
Hide resolved
kashike
approved these changes
Feb 15, 2024
electronicboy
approved these changes
Feb 15, 2024
rybot666
added a commit
to GemstoneGG/Velocity-CTD
that referenced
this pull request
May 3, 2024
This reverts commit ecf936f.
rybot666
added a commit
to GemstoneGG/Velocity-CTD
that referenced
this pull request
May 3, 2024
This reverts commit ecf936f.
rybot666
added a commit
to GemstoneGG/Velocity-CTD
that referenced
this pull request
May 9, 2024
This reverts commit ecf936f.
rybot666
added a commit
to GemstoneGG/Velocity-CTD
that referenced
this pull request
May 13, 2024
This reverts commit ecf936f.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This would solve a rare "too many concurrent streams" error.