Improved configuration version handling #788
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Collides with #772 |
Merged
|
superseded by #1111 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the user is "forced" to handle the configuration update on their own, deleting the configuration they have in place to add the new options, whereas the job should be handled by Velocity, especially with a patch version being developed
3.1.2.This pull request replaces the old logic for handling version 1.0 and 2.0 configuration to a single migration. This would also allow more migrations to be done in case more configuration options or changes are added in the future, e.g. #666. Possibly resolves #733 , but only for the new options that may be added from now on