Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Console output has issues with new lines/spam #188

Closed
mikroskeem opened this issue Nov 8, 2017 · 5 comments · Fixed by #249
Closed

Console output has issues with new lines/spam #188

mikroskeem opened this issue Nov 8, 2017 · 5 comments · Fixed by #249

Comments

@mikroskeem
Copy link
Contributor

This is only happening when plugin spits out 3-4 lines in a row. At first, line ends up being inserted after input prompt and if that happens frequently enough, Log4j2 spits out an error.

Log snippet & stack trace: https://paste.wut.ee/ezerajafor.md

Waterfall version: This server is running Waterfall version git:Waterfall-Bootstrap:1.12-SNAPSHOT:261741a:155 by md_5

@mikroskeem mikroskeem changed the title Console output has issues with new lines Console output has issues with new lines/spam Nov 8, 2017
@mikroskeem
Copy link
Contributor Author

If that helps, I am using SLF4J logger (as plugin is multiplatform and uses SLF4J widely) and getting it using LoggerFactory.getLogger(...)

@jamierocks
Copy link
Contributor

Ref @Minecrell

@stephan-gh
Copy link
Contributor

I can't reproduce this. It's likely some kind of race condition that only happens if a message is logged while the console reader is changing its state (e.g. it's done reading or it starts reading again).

Do you have a reliable way to reproduce this?

@k-jiang
Copy link

k-jiang commented Dec 17, 2017

Same issue here. To reproduce it, you just need to spam command in the console frequently then you will see the exception.
In my case I have RedisBungee installed with Waterfall build 160. The command I have tested is RedisBungee's modified glist.
I'm guessing it doesn't have to be the commands from RedisBungee, any plugins will do so, even the basic commands from BungeeCord.
If you need any help on testing please let me know. I'm here to help. @Minecrell

@Black-Hole
Copy link
Contributor

Seems like jline/jline3#183

jamierocks pushed a commit that referenced this issue Jul 18, 2018
Fixes a long-standing race condition in TerminalConsoleAppender,
that eventually resulted in IllegalStateExceptions or duplicate
input prompts.

Fixes #242, Fixes #188
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants