Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support Request objects in methods #103

Merged
merged 6 commits into from
Aug 17, 2021
Merged

Support Request objects in methods #103

merged 6 commits into from
Aug 17, 2021

Conversation

PaperStrike
Copy link
Owner

@PaperStrike PaperStrike commented Aug 17, 2021 •
edited

Motivation and Context

  • Support passing a Request object as the first parameter to loadURL, weakLoadURL, and switchDOM.
  • Support POST submissions.
  • loadURL -> load.
  • weakLoadURL -> weakLoad.

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Refactor (no bug fix and new feature but improvements)

Checklist:

  • My change requires new tests.
  • I have added tests to cover my changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@PaperStrike
Support Request objects in methods
99e8f9a 
- Includes loadURL, weakLoadURL, and switchDOM
@PaperStrike PaperStrike added enhancement New feature or request minor Pull requests that require a minor version update labels Aug 17, 2021
@PaperStrike PaperStrike added breaking Might break something else major Pull requests that require a major version update and removed minor Pull requests that require a minor version update labels Aug 17, 2021
@PaperStrike PaperStrike merged commit 40d3c96 into main Aug 17, 2021
@PaperStrike PaperStrike deleted the request-like-fetch branch August 17, 2021 10:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
breaking Might break something else enhancement New feature or request major Pull requests that require a major version update
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@PaperStrike