Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Append submitter entry in submissions #212

Merged
merged 2 commits into from
Oct 16, 2021
Merged

Append submitter entry in submissions #212

merged 2 commits into from
Oct 16, 2021

Conversation

PaperStrike
Copy link
Owner

Motivation and Context

In form submissions, the form entry list should include the submitter's entry, if the submitter is not disabled and has a non-empty name. See the algorithm to construct the entry list, which the form submission algorithm uses.

There isn't a straightforward API to construct the entry list of a form given a submitter, yet. Track the possible future solution here in whatwg/xhr#262.

How Has This Been Tested?

Unfortunately, there isn't a plan for Submission lib's test cases, yet.

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Refactor (no bug fix and new feature but improvements)

Checklist:

  • My change requires new tests.
  • I have added tests to cover my changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@PaperStrike PaperStrike added the bug Something isn't working label Oct 15, 2021
@PaperStrike PaperStrike merged commit 832e098 into main Oct 16, 2021
@PaperStrike PaperStrike deleted the submitter-entry branch October 16, 2021 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant