Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid write to session storage when init #89

Merged
merged 1 commit into from
Aug 11, 2021

Conversation

PaperStrike
Copy link
Owner

@PaperStrike PaperStrike commented Aug 10, 2021

Motivation and Context

In LazyHistory lib,

  • Fix undefined writing to session storage,
  • Adapt strict TypeScript,
  • Reorder class properties for readability,
  • Use private field instead of ES # for readability and smaller bundle size.

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Refactor (no bug fix and new feature but improvements)

Checklist:

  • My change requires new tests.
  • I have added tests to cover my changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

- Adapt strict TypeScript
@PaperStrike PaperStrike added the bug Something isn't working label Aug 10, 2021
@PaperStrike PaperStrike merged commit b58bafc into main Aug 11, 2021
Adapt recommended TypeScript rules automation moved this from In Progress to Done Aug 11, 2021
@PaperStrike PaperStrike deleted the strict-ts/lazy-history-fix branch August 11, 2021 10:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

1 participant