Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapt recommended TS rules #95

Merged
merged 4 commits into from
Aug 12, 2021
Merged

Adapt recommended TS rules #95

merged 4 commits into from
Aug 12, 2021

Conversation

PaperStrike
Copy link
Owner

Motivation and Context

This adapts the following rules, without bug fixes or new features (if any, use seperate PR):

TS Config, from tsconfig/bases:

{
  "compilerOptions": {
    "target": "ES2015",
    "module": "commonjs",
    "strict": true,
    "esModuleInterop": true,
    "skipLibCheck": true,
    "forceConsistentCasingInFileNames": true
  }
}

ESLint Config, from typescript-eslint/eslint-plugin:

{
  "extends": [
    "plugin:@typescript-eslint/recommended",
    "plugin:@typescript-eslint/recommended-requiring-type-checking"
  ]
}

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Refactor (no bug fix and new feature but improvements)

Checklist:

  • My change requires new tests.
  • I have added tests to cover my changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@PaperStrike PaperStrike added enhancement New feature or request minor Pull requests that require a minor version update labels Aug 12, 2021
@PaperStrike PaperStrike added this to In Progress in Adapt recommended TypeScript rules via automation Aug 12, 2021
@PaperStrike PaperStrike merged commit b787ee3 into main Aug 12, 2021
Adapt recommended TypeScript rules automation moved this from In Progress to Done Aug 12, 2021
@PaperStrike PaperStrike deleted the strict-ts/main branch August 12, 2021 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request minor Pull requests that require a minor version update
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

1 participant