Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for autoscaling deployments #305

Merged
merged 8 commits into from
Jul 1, 2020

Conversation

BartoszCki
Copy link
Contributor

No description provided.

@BartoszCki BartoszCki marked this pull request as draft June 16, 2020 07:28
@BartoszCki BartoszCki marked this pull request as ready for review June 17, 2020 12:10
@@ -149,7 +149,7 @@ def _get_instance(self, response, **kwargs):
objects = self._parse_object(response.data, **kwargs)
except GradientSdkError:
raise
except Exception:
except Exception as e:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this necessary?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch

@BartoszCki BartoszCki marked this pull request as draft June 17, 2020 13:01
@BartoszCki BartoszCki marked this pull request as ready for review July 1, 2020 08:54
@BartoszCki BartoszCki merged commit 10bfd83 into master Jul 1, 2020
@BartoszCki BartoszCki deleted the PS-13955-Add_support_for_autoscaling_deployments branch July 1, 2020 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants