This repository has been archived by the owner on Jun 8, 2023. It is now read-only.
feat: optionally return all raw email addresses for user #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| if (self._allRawEmails) { | ||
| profile.emails = json.map(function (email) { | ||
| var mappedEmail = Object.assign(email, { value: email.email }); |
There was a problem hiding this comment.
How do you know which email is the primary one? Should we add type to these? See: http://www.passportjs.org/docs/profile/
There was a problem hiding this comment.
here's a sample json object:
[ { primary: true,
verified: true,
visibility: 'private',
value: 'bob.pineapple@gmail.com' },
{ primary: false,
verified: true,
visibility: null,
value: 'pineapple@users.noreply.github.com' },
{ primary: false,
verified: true,
visibility: null,
value: 'bob@pineapple.com' } ]
There was a problem hiding this comment.
Ah, is this what the response looks like? [ { "email": "octocat@github.com", "verified": true, "primary": true, "visibility": "public" } ]
There was a problem hiding this comment.
my map just transforms these objects to have a value key, which seems to be a convention across passport addons
ultrabluewolf
approved these changes
Feb 7, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adopted in part from jaredhanson#27