Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue with newer Clangs. #18

Closed
shayneoneill opened this issue Aug 27, 2019 · 3 comments
Closed

Issue with newer Clangs. #18

shayneoneill opened this issue Aug 27, 2019 · 3 comments

Comments

@shayneoneill
Copy link

I'm trying to get this working with a newer clang (My system has clang 7 or 8, cant remember , I'm on a different machine right now.

First issue is

https://www.mail-archive.com/cfe-commits@lists.llvm.org/msg73202.html

QualTypeNames.h has been moved into AST

Also in include/clang_type_name.hpp theres a reference to and the compiler isnt sure if the right namespace refers to clang::PointerType or llvm::PointerType

out of unfamiliarity I just replaced it with clang::PointerType and it compiled. But I dont actually know if it'll explode when pressed or not. I'm just not particularly familiar with C++, alas.

I'd push a pull request but I'm not currently sure how :/

@shayneoneill
Copy link
Author

Oh looking at PRs #8 seems to cover it

@docelic
Copy link
Collaborator

docelic commented May 8, 2020

This should be fixed soon. I tested with 6 and 7, and contributions from @kalinon indicate a working version with 8.

@docelic
Copy link
Collaborator

docelic commented May 10, 2020

Closing as I believe the issue reported should be fixed at this time. Please reopen if the problem persists. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants