LLVM 6 support #8
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Papierkorb
reviewed
Sep 20, 2018
| @@ -438,7 +442,7 @@ namespace ClangTypeName { | |||
| bool WithGlobalNsPrefix) { | |||
| // In case of myType* we need to strip the pointer first, fully | |||
| // qualify and attach the pointer once again. | |||
| if (isa<PointerType>(QT.getTypePtr())) { | |||
| if (isa<clang::PointerType>(QT.getTypePtr())) { | |||
There was a problem hiding this comment.
Can you add a small comment that clang:: prevents a warning?
|
That's pretty rad, thanks, I'll take a look later! |
|
bump! |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
QualTypeNames.hmoved fromTooling/CoretoAST;PointerType->clang::PointerTypefixes compilation warninginclude/clang_type_name.hpp:445:12: error: reference to 'PointerType' is ambiguous;QualTypeNames.hremoved fromtype_helper.cppbecause it will be included byclang_type_name.hpp6 lines later.