Document type for the Clang parser #84
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Which is? |
|
Nested anonymous types: #85 |
|
Now I see where you're coming from. As I don't squash PRs could you update your PR with better commit titles? Thanks! |
HertzDevil
force-pushed
the
parser-document
branch
from
0725ad2
to
e2c21f7
Compare
|
done |
Papierkorb
reviewed
Sep 1, 2020
| @@ -66,4 +68,11 @@ struct CopyPtr { | |||
| const T &operator*() const { return *this->ptr; } | |||
| }; | |||
|
|
|||
| // compatibility for C++11 | |||
| template< typename T, typename... Args > | |||
| std::unique_ptr<T> make_unique(Args&&... args) | |||
There was a problem hiding this comment.
In the future I don't think we'll want to support C++11 compilers. When I started this I think I had C++14-ish in mind, I think it's safe nowadays to move on to C++17. This will also enable us to use std::variant and std::optional in certain places.
|
Thanks! 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This refactor brings the equivalent of Crystal's
Bindgen::Parser::Documentto the Clang parser.Alone it doesn't do anything new, but passing the whole document around allows each registered AST handler to insert multiple parser values (there will be a use case for this).