Correctly return from GLib idle/timeout calls

material-shell · Jul 11, 2019 · 1182728 · 1182728
1 parent 12c6bea
commit 1182728
Show file tree

Hide file tree

Showing 8 changed files with 10 additions and 1 deletion.
diff --git a/extension.js b/extension.js
@@ -45,6 +45,7 @@ function enable() {
                 module.enable();
             });
         });
+        return GLib.SOURCE_REMOVE;
     });
 }
 

diff --git a/module/leftPanel/verticalisePanel/verticalisePanelSubModule.js b/module/leftPanel/verticalisePanel/verticalisePanelSubModule.js
@@ -92,6 +92,7 @@ var VerticalisePanelSubModule = class VerticalisePanelSubModule {
         // 1- Set all List container to vertical
         GLib.idle_add(GLib.PRIORITY_DEFAULT, () => {
             this.recursivelySetVertical(this.panel, true);
+            return GLib.SOURCE_REMOVE;
         });
 
         // 2- Override the allocate function of the panel to display the PanelBoxes vertically

diff --git a/module/noTitleBarModule.js b/module/noTitleBarModule.js
@@ -14,6 +14,7 @@ var NoTitleBarModule = class NoTitleBarModule {
             if (!this._handleWindow(window)) return;
             GLib.idle_add(GLib.PRIORITY_DEFAULT, () => {
                 this.toggleTitleBar(this.getWindowXID(window), true);
+                return GLib.SOURCE_REMOVE;
             });
         });
     }

diff --git a/superWorkspace/superWorkspace.js b/superWorkspace/superWorkspace.js
@@ -276,9 +276,10 @@ var SuperWorkspace = class SuperWorkspace {
             this.emitInProgress = false;
 
             if (this.destroyed) {
-                return;
+                return GLib.SOURCE_REMOVE;
             }
             this.emit('windows-changed');
+            return GLib.SOURCE_REMOVE;
         });
     }
 

diff --git a/tilingManager/tilingLayouts/baseTilingLayout.js b/tilingManager/tilingLayouts/baseTilingLayout.js
@@ -149,6 +149,7 @@ var BaseTilingLayout = class BaseTilingLayout {
             //If we don't have actor we hope to get it in the next loop
             GLib.idle_add(GLib.PRIORITY_DEFAULT, () => {
                 this.callSafely(metaWindow, callback, true);
+                return GLib.SOURCE_REMOVE;
             });
         } else {
             // Can't do shit for now

diff --git a/tilingManager/tilingManager.js b/tilingManager/tilingManager.js
@@ -43,6 +43,7 @@ var TilingManager = class TilingManager {
                                 }
                             }
                         );
+                        return GLib.SOURCE_REMOVE;
                     });
                 }
             });
@@ -119,6 +120,7 @@ var TilingManager = class TilingManager {
             }
             log('tile windows end');
             this.tilingInProgress = false;
+            return GLib.SOURCE_REMOVE;
         });
     }
 };
diff --git a/widget/backdrop.js b/widget/backdrop.js
@@ -48,6 +48,7 @@ var Backdrop = GObject.registerClass(
                             this.window,
                             this
                         );
+                        return GLib.SOURCE_REMOVE;
                     });
                 } else {
                     this.followWindow();

diff --git a/widget/taskBar.js b/widget/taskBar.js
@@ -37,6 +37,7 @@ var TaskBar = GObject.registerClass(
                 this.updateItems();
                 GLib.timeout_add(GLib.PRIORITY_DEFAULT, 50, () => {
                     this._animateActiveIndicator();
+                    return GLib.SOURCE_REMOVE;
                 });
             });