This repository has been archived by the owner on Jan 25, 2024. It is now read-only.
Symbols and overrides #129
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
siliconivan
reviewed
Oct 21, 2020
| return child.name ?? 'var'; | ||
| } | ||
| } | ||
| // this should never happen. |
This was referenced Oct 21, 2020
This was
linked to
issues
Oct 21, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Lots of changes.
Symbol names from MasterSymbol are added and when name collisions happen it appends number for unique name.
Overrides for symbols are passed in as optional parameters to the Master Symbol.
Symbol instance now wraps the SymbolMaster in a LayoutBuilder to pass constraints in, this works currently but not if the page only has one symbol in it, because it doesn't wrap a flex object on Symbol only artboards. I'll look into that next.