This repository has been archived by the owner on Jan 25, 2024. It is now read-only.
Hotfix/generator manager #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 13 commits
August 19, 2020 16:37
Ihuds577
reviewed
Aug 23, 2020
Ihuds577
reviewed
Aug 23, 2020
Ihuds577
reviewed
Aug 23, 2020
Ihuds577
reviewed
Aug 23, 2020
lib/generation/flutter_project_builder/flutter_project_builder.dart
Outdated
Show resolved
Hide resolved
Ihuds577
reviewed
Aug 23, 2020
Ihuds577
reviewed
Aug 23, 2020
added 2 commits
August 23, 2020 15:10
x64Eddie
approved these changes
Aug 24, 2020
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Generator was not generating variables, constructor nor dependencies.
First cause was the fact that generator had multiple managers, so whenever a variable, constructor or dependency were added to the manager, was getting lost. In other words, the manager helping writing the files was not the same manager receiving the fields.
This PR removed the unnecessary managers, helped plugins to be more easy to understand, & cleaned the code a bit.