Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GitHub integration UI implemented #1103

Closed
12 tasks
ackernaut opened this issue Jun 21, 2017 · 3 comments
Closed
12 tasks

GitHub integration UI implemented #1103

ackernaut opened this issue Jun 21, 2017 · 3 comments

Comments

@ackernaut
Copy link
Member

ackernaut commented Jun 21, 2017

Enhancement

  • GitHub is listed under Team > Integrations (perhaps with some metadata [# users, # repos]
  • Can drill down to GitHub (expands or sub view or modals at some point, but trying to avoid)
  • A single GitHub provider is added per user, per team
  • Authenticated user can remove or refresh her token
  • Authenticated users are automatically integrated with existing integrated repos that they are a member of on GH
  • A user can add repos once she is authenticated
  • A team lead or authenticated repo user can edit repo integration
  • Repo configuration
    • Can remove repo
    • Authenticated users are mapped automatically (but can be changed?) —FUTURE #gh-import
    • Can map un-authenticated Parabol users with GH repo users —FUTURE #gh-import
    • Can map GH labels to Parabol metadata (status, etc.) —FUTURE #gh-import
    • Can sync issues/PRs (for imports, create PR?) —FUTURE #gh-import

Latest visual concepts (most up-to-date in Figma):

team-provider-github 2x

and…

team-integration-github-full-sync 2x

Estimated effort: 15 points (see CONTRIBUTING.md)

@ackernaut ackernaut added this to the Epic 6 GitHub Integration Lite milestone Jun 21, 2017
@ackernaut
Copy link
Member Author

ackernaut commented Jun 21, 2017

For version v0.0.0 do we allow for both multiple accounts/orgs and repos?

Basically on Product team we could have multiple:

  • mattkrick/cashay
  • parabolinc/action
  • parabolinc/private-repo
  • parabolinc/yet-another-repo

[see Figma internally]

@ackernaut
Copy link
Member Author

Original questions for reference (going to update 1st comment with specs and update title):

Pondering provider/integration logic as it pertains to GitHub integration v0.0.0 and future…

  • If JH adds 3 repos to Team A and MK also has access to those repos, do we automatically integrate for MK behind the scenes as soon as MK authorizes his GH account?
  • If MK was the only one to integrate with a repo on Team A and he leaves, do we just downgrade all cards to non-synced, editable cards (and leave the link to the issue, now part of the editable content)? [see the visual in Figma/internal]
  • Does it make sense to have a tab under user settings for integrations (my authorized accounts/providers)?
  • Does it make sense that team settings is more about integrations in the context of that team (but I can authorize inline—no need to go to my user settings > integrations)?

@ackernaut
Copy link
Member Author

We are starting with single token per user per team. If I have multiple accounts I need to invite one or the other to the integrated repo (on GitHub) in order to have access via Parabol integration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants