Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

migrate away from legacy context API #2475

Closed
1 task
mattkrick opened this issue Nov 3, 2018 · 4 comments · Fixed by #2622
Closed
1 task

migrate away from legacy context API #2475

mattkrick opened this issue Nov 3, 2018 · 4 comments · Fixed by #2622
Assignees
@mattkrick
Projects
Sprint Board

Comments

@mattkrick
Copy link
Member

react 16.6 strict mode has deprecated legacy context API. we'll need to do something to do the same to prepare for v17

AC

  • legacy context API is removed

effort: 11 points
@mattkrick mattkrick added the chore label Nov 3, 2018
@mattkrick mattkrick added this to the Chores milestone Nov 3, 2018
@mattkrick mattkrick added this to To Prioritize in Sprint Board via automation Nov 3, 2018
@jordanh
Copy link
Contributor

jordanh commented Nov 12, 2018

This will affect our toast component...

@jordanh jordanh moved this from To Prioritize to To Do in Sprint Board Nov 12, 2018
@jordanh jordanh moved this from To Do to Backlog in Sprint Board Nov 12, 2018
@mattkrick
Copy link
Member Author

true, stuck on #2360 #2327

@jordanh jordanh moved this from Backlog to To Do in Sprint Board Nov 12, 2018
@mattkrick mattkrick moved this from To Do to Stuck in Sprint Board Nov 20, 2018
@mattkrick
Copy link
Member Author

stuck on react-redux because we need to sometimes access the store itself.
using v6.0.0-beta.2 will break redux-form
reduxjs/react-redux#1083

@jordanh jordanh moved this from Stuck to Backlog in Sprint Board Nov 27, 2018
@jordanh jordanh moved this from Backlog to To Prioritize in Sprint Board Nov 27, 2018
@jordanh jordanh moved this from To Prioritize to Backlog in Sprint Board Dec 11, 2018
@mattkrick
Copy link
Member Author

stuck on #2172

@mattkrick mattkrick mentioned this issue Jan 9, 2019
Closed
2 tasks
This was referenced Jan 29, 2019
Closed
Merged
@mattkrick mattkrick moved this from Backlog to In Progress in Sprint Board Feb 1, 2019
@mattkrick mattkrick mentioned this issue Feb 2, 2019
Closed
1 task
@ghost ghost assigned mattkrick Feb 2, 2019
@ghost ghost added the pr review label Feb 2, 2019
@mattkrick mattkrick moved this from In Progress to In Review in Sprint Board Feb 4, 2019
@mattkrick mattkrick mentioned this issue Feb 4, 2019
Merged
5 tasks
@mattkrick mattkrick moved this from In Review to Stuck in Sprint Board Feb 5, 2019
@mattkrick mattkrick moved this from Stuck to In Review in Sprint Board Feb 6, 2019
@ghost ghost removed the pr review label Feb 8, 2019
@jordanh jordanh moved this from In Review to Done in Sprint Board Feb 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mattkrick mattkrick

Labels
None yet
Projects
No open projects
Sprint Board
  
Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove legacy context & Persisted queries ParabolInc/parabol
2 participants
@jordanh @mattkrick