feat: Add recurring retros #9311
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dschoordsch
force-pushed
the
feat/9291/recurringRetros
branch
from
9e5a5cd
to
561cf67
Compare
Dschoordsch
force-pushed
the
feat/9291/recurringRetros
branch
from
672aea1
to
b61d802
Compare
Dschoordsch
changed the base branch from
master
to
chore/9342/recurringRetrosFeatureFlag
Base automatically changed from
chore/9342/recurringRetrosFeatureFlag
to
master
January 18, 2024 08:56
nickoferrall
approved these changes
Jan 22, 2024
There was a problem hiding this comment.
The code looks good, and it's working for me. I think we should find a way to get recurrence and the Gcal "Schedule" flow working together, but I know you're working on that in Slack with Alicia.
I also think that if it's a retro template, we shouldn't refer to "Standups" in the placeholder on description text:
|
@nickoferrall The placeholder is fixed in one of the upcoming PRs. |
24 tasks
mattkrick
added a commit
that referenced
this pull request
Jan 23, 2024
* fix: handle breaking syntax in pr body (#9368) Signed-off-by: Matt Krick <matt.krick@gmail.com> * feat: support SERVER_SECRET rotations gracefully (#9360) Signed-off-by: Matt Krick <matt.krick@gmail.com> * chore: Prettify "Time's up" Slack message (#9352) * chore: Prettify "Time's up" Slack message * Prettify Mattermost as well * feat: Add recurring retros (#9311) * chore: Add recurring retros feature flag * Make it an org flag * feat: Recurring retros * Only show the recurring settings if the feature flag is set * Formatting * Add processRecurrence test for retros * Remove debug output * Minor fixes * Fix recurrence label colours in meeting dash * fix: render activity library tooltip (#9376) * chore(release): release v7.14.0 (#9369) Co-authored-by: parabol-release-bot[bot] <150284312+parabol-release-bot[bot]@users.noreply.github.com> --------- Signed-off-by: Matt Krick <matt.krick@gmail.com> Co-authored-by: Matt Krick <matt.krick@gmail.com> Co-authored-by: Georg Bremer <github@dschoordsch.de> Co-authored-by: Nick O'Ferrall <nickoferrall@gmail.com> Co-authored-by: parabol-release-bot[bot] <150284312+parabol-release-bot[bot]@users.noreply.github.com>
jordanh
pushed a commit
that referenced
this pull request
Feb 8, 2024
* chore: Add recurring retros feature flag * Make it an org flag * feat: Recurring retros * Only show the recurring settings if the feature flag is set * Formatting * Add processRecurrence test for retros * Remove debug output * Minor fixes * Fix recurrence label colours in meeting dash
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #9291
[Please include a summary of the changes and the related issue]
Demo
https://www.loom.com/share/df6356fffd4e419d8c33384fb9f6fb34?sid=3d3440ae-44d1-4027-a458-073897b66e85
Testing scenarios
Try process recurrence with a retro
recurringRetrosMeetingRetrospective.createdAt,MeetingRetrospective.scheduledEndTimein Rethink andMeetingSeries.recurrenceRulein Postgres to one day behind and runscheduleRecurrencemutation to see the meeting restart, see DemoSmoke test nothing broke
Final checklist
One Review Requiredif the PR introduces only minor changes, does not contain any architectural changes or does not introduce any new patterns and I think one review is sufficient'