Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Prettify "Time's up" Slack message #9352

Merged
merged 2 commits into from
Jan 22, 2024

Conversation

Dschoordsch
Copy link
Contributor

Format the "Time's up" message similar to the rest of the messages. MSTeams seems to have a nicely formatted message already.

Demo

Before:
Screenshot 2024-01-18 at 15 35 26
Now:
Screenshot 2024-01-18 at 15 34 18
Screenshot 2024-01-18 at 15 36 45

Testing scenarios

For ease of testing I replaced

IntegrationNotifier.startMeeting(dataLoader, meetingId, teamId)

with

  IntegrationNotifier.endTimeLimit(dataLoader, meetingId, teamId)

and just started a check-in

  • check Slack
  • check Mattermost

Final checklist

  • I checked the code review guidelines
  • I have added Metrics Representative as reviewer(s) if my PR invovles metrics/data/analytics related changes
  • I have performed a self-review of my code, the same way I'd do it for any other team member
  • I have tested all cases I listed in the testing scenarios and I haven't found any issues or regressions
  • Whenever I took a non-obvious choice I added a comment explaining why I did it this way
  • I added the label Skip Maintainer Review Indicating the PR only requires reviewer review and can be merged right after it's approved if the PR introduces only minor changes, does not contain any architectural changes or does not introduce any new patterns and I think one review is sufficient'
  • PR title is human readable and could be used in changelog

@Dschoordsch Dschoordsch merged commit 73aac5f into master Jan 22, 2024
5 checks passed
@Dschoordsch Dschoordsch deleted the chore/prettifyTimesUp/SlackMessage branch January 22, 2024 18:02
@github-actions github-actions bot mentioned this pull request Jan 23, 2024
24 tasks
mattkrick added a commit that referenced this pull request Jan 23, 2024
* fix: handle breaking syntax in pr body (#9368)

Signed-off-by: Matt Krick <matt.krick@gmail.com>

* feat: support SERVER_SECRET rotations gracefully (#9360)

Signed-off-by: Matt Krick <matt.krick@gmail.com>

* chore: Prettify "Time's up" Slack message (#9352)

* chore: Prettify "Time's up" Slack message

* Prettify Mattermost as well

* feat: Add recurring retros (#9311)

* chore: Add recurring retros feature flag

* Make it an org flag

* feat: Recurring retros

* Only show the recurring settings if the feature flag is set

* Formatting

* Add processRecurrence test for retros

* Remove debug output

* Minor fixes

* Fix recurrence label colours in meeting dash

* fix: render activity library tooltip (#9376)

* chore(release): release v7.14.0 (#9369)

Co-authored-by: parabol-release-bot[bot] <150284312+parabol-release-bot[bot]@users.noreply.github.com>

---------

Signed-off-by: Matt Krick <matt.krick@gmail.com>
Co-authored-by: Matt Krick <matt.krick@gmail.com>
Co-authored-by: Georg Bremer <github@dschoordsch.de>
Co-authored-by: Nick O'Ferrall <nickoferrall@gmail.com>
Co-authored-by: parabol-release-bot[bot] <150284312+parabol-release-bot[bot]@users.noreply.github.com>
jordanh pushed a commit that referenced this pull request Feb 8, 2024
* chore: Prettify "Time's up" Slack message

* Prettify Mattermost as well
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants