feat: support SERVER_SECRET rotations gracefully #9360
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Matt Krick <matt.krick@gmail.com>
nickoferrall
approved these changes
Jan 22, 2024
4 tasks
24 tasks
mattkrick
added a commit
that referenced
this pull request
Jan 23, 2024
* fix: handle breaking syntax in pr body (#9368) Signed-off-by: Matt Krick <matt.krick@gmail.com> * feat: support SERVER_SECRET rotations gracefully (#9360) Signed-off-by: Matt Krick <matt.krick@gmail.com> * chore: Prettify "Time's up" Slack message (#9352) * chore: Prettify "Time's up" Slack message * Prettify Mattermost as well * feat: Add recurring retros (#9311) * chore: Add recurring retros feature flag * Make it an org flag * feat: Recurring retros * Only show the recurring settings if the feature flag is set * Formatting * Add processRecurrence test for retros * Remove debug output * Minor fixes * Fix recurrence label colours in meeting dash * fix: render activity library tooltip (#9376) * chore(release): release v7.14.0 (#9369) Co-authored-by: parabol-release-bot[bot] <150284312+parabol-release-bot[bot]@users.noreply.github.com> --------- Signed-off-by: Matt Krick <matt.krick@gmail.com> Co-authored-by: Matt Krick <matt.krick@gmail.com> Co-authored-by: Georg Bremer <github@dschoordsch.de> Co-authored-by: Nick O'Ferrall <nickoferrall@gmail.com> Co-authored-by: parabol-release-bot[bot] <150284312+parabol-release-bot[bot]@users.noreply.github.com>
jordanh
pushed a commit
that referenced
this pull request
Feb 8, 2024
Signed-off-by: Matt Krick <matt.krick@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
support server secret rotations without our app trying to DOS us.
before the client would see it failed to connect & keep retrying forever because it had succeeded in the past.
now it realized that just because it succeeded in the past, it may not succeed now.
Demo
https://www.loom.com/share/891a552c4f3c4e3d99d5f71d9dcdcdcb?sid=00bfa14e-60e7-406f-8ebf-68c42ebb3723
Testing scenarios