Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add slack notification for mention and kudos in reflections #9377

Merged
merged 5 commits into from
Jan 25, 2024

Conversation

igorlesnenko
Copy link
Contributor

@igorlesnenko igorlesnenko commented Jan 23, 2024

image

Enabling slack notifications for mentions and kudos in retro reflections
Previous PR: #9354

How to test:

  • You need 2 users in one team for testing
  • Add slack integration for the second user
  • Start meeting as the first user but do not join as the second user
  • As the first user add various reflections with kudos and mentions
  • Complete the meeting
  • See the second user received slack notifications for mentions and kudos
  • Test with non-anonymous reflections
  • Smoke test that standup slack notifications still working

Copy link
Contributor

@Dschoordsch Dschoordsch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works

Base automatically changed from retro-mention to master January 25, 2024 01:35
@igorlesnenko igorlesnenko merged commit bd0347b into master Jan 25, 2024
4 checks passed
@igorlesnenko igorlesnenko deleted the retro-mention-slack branch January 25, 2024 02:17
@github-actions github-actions bot mentioned this pull request Jan 31, 2024
24 tasks
jordanh pushed a commit that referenced this pull request Feb 8, 2024
)

* feat: add notifications for mention in reflections and show kudos preview

* Fix types

* feat: add slack notification for mention and kudos in reflections

* use const
igorlesnenko added a commit that referenced this pull request Feb 12, 2024
* fix: add suggested vscode extensions (#9382)

Signed-off-by: Matt Krick <matt.krick@gmail.com>

* feat: add notifications for mention in reflections and show kudos preview (#9354)

* feat: add notifications for mention in reflections and show kudos preview

* Fix types

* chore(kudos): track kudos type and meeting type in kudosSent event (#9373)

* senderName senderPicture

* Fix tests

* Add TODO comment to use single Mentioned notification everywhere

* feat: add slack notification for mention and kudos in reflections (#9377)

* feat: add notifications for mention in reflections and show kudos preview

* Fix types

* feat: add slack notification for mention and kudos in reflections

* use const

* feat: support globs for org approvals (#9367)

* feat: refactor 4 sql queries to kysely

Signed-off-by: Matt Krick <matt.krick@gmail.com>

* feat: refactor removeApprovalOD to kysely

Signed-off-by: Matt Krick <matt.krick@gmail.com>

* feat: support wildcards in OrgApprovalDomains rules

Signed-off-by: Matt Krick <matt.krick@gmail.com>

* support org approval for invites

Signed-off-by: Matt Krick <matt.krick@gmail.com>

---------

Signed-off-by: Matt Krick <matt.krick@gmail.com>

* feat: Release team insights (#9385)

Reverse the feature flag.

* feat: Allow retro meeting series naming (#9348)

* feat: Add meeting series end options for retros (#9370)

* feat: Add meeting series end options for retros

* Add update recurrence settings modals

* Stay on prettier major version 2

Don't reformat the whole codebase without reason.

* Run prettier :-/

* Sneak in change for new meeting series subscription

We were loading the new meeting with the activeMeetingsForTeamId
dataloader which was not invalidated after the meeting was modified with
the meeting series data.

* await had no effect

* fix: fix recreating invite link in case of expiration (#9222)

* fix: fix recreating invite link in case of expiration

* Fix token refetch

* fix: fix slack resonse replied anonymous notification (#9390)

* chore(release): release v7.15.0 (#9383)

Co-authored-by: parabol-release-bot[bot] <150284312+parabol-release-bot[bot]@users.noreply.github.com>

* fix(env): typo in AZURE_DEVOPS vars (#9396)

* chore: update Ironbank GH action dependencies (#9393)

* Update ironbank GH actions

* update description

* chore(deps): bump nodemailer (#9399)

Signed-off-by: Matt Krick <matt.krick@gmail.com>

* fix: handle all types of errors in sendToSentry (#9387)

Signed-off-by: Matt Krick <matt.krick@gmail.com>

* fix: fix accepting invite always required email verification (#9404)

* chore(release): release v7.15.1 (#9397)

Co-authored-by: parabol-release-bot[bot] <150284312+parabol-release-bot[bot]@users.noreply.github.com>

---------

Signed-off-by: Matt Krick <matt.krick@gmail.com>
Co-authored-by: Matt Krick <matt.krick@gmail.com>
Co-authored-by: Igor Lesnenko <igor.lesnenko@gmail.com>
Co-authored-by: Georg Bremer <github@dschoordsch.de>
Co-authored-by: parabol-release-bot[bot] <150284312+parabol-release-bot[bot]@users.noreply.github.com>
Co-authored-by: Rafa <101704572+rafaelromcar-parabol@users.noreply.github.com>
Co-authored-by: Dale Bumblis <135627447+dbumblis-parabol@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants