feat: speed up ai search #9421
Merged
feat: speed up ai search #9421
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nickoferrall
added
the
Skip Maintainer Review
igorlesnenko
approved these changes
Feb 14, 2024
| @@ -221,9 +221,11 @@ class OpenAIServerManager { | |||
| }) | |||
|
|
|||
| const templateResponse = (response.choices[0]?.message?.content?.trim() as string) ?? null | |||
| return JSON.parse(templateResponse) as AITemplateSuggestion | |||
| const parsedResponse = JSON5.parse(templateResponse) | |||
There was a problem hiding this comment.
Just curious, why replaced with JSON5?
There was a problem hiding this comment.
3.5-turbo doesn't have the JSON parse feature that GPT-4 has, so we need to parse it ourselves
24 tasks
nickoferrall
added a commit
that referenced
this pull request
Feb 19, 2024
* chore: Add more Atlassian logging (#9405) * chore: Add more Atlassian logging Mainly associate the logs with the traces so it's possible to check which GraphQL request caused a certain debug output. * Less code shuffling * Cleanup log directories Put them in the dev folder so they're out of sight. * fix: fix kudos in standups in nested lists (#9412) * Fix: fix kudos in standups in nested lists * fix test * chore(release): release v7.15.2 (#9414) Co-authored-by: parabol-release-bot[bot] <150284312+parabol-release-bot[bot]@users.noreply.github.com> * chore: update 3d secure card number in release_test.md (#9394) Previous 3d secure card number does not work anymore and I don't see it in the stripe docs https://stripe.com/docs/testing?testing-method=card-numbers#regulatory-cards * chore: bump node to v20.11.0 (#9410) Signed-off-by: Matt Krick <matt.krick@gmail.com> * chore: add embeddings table migration (#9372) * chore: add embeddings table migration * chore: code review changes * feat: auto-add pgvector extension in production Also: - fix: corrects types in standaloneMigrations.ts - fix: silly things I missed in the addEmbeddingTables migration * fix: check for POSTGRES_USE_PGVECTOR * fix: POSTGRES_USE_PGVECTOR strict check for === 'true' * feat: speed up ai search (#9421) * fix: not all jira projects are displayed in the list if there are a lot of them (#9422) * chore(release): release v7.16.0 (#9419) Co-authored-by: parabol-release-bot[bot] <150284312+parabol-release-bot[bot]@users.noreply.github.com> --------- Signed-off-by: Matt Krick <matt.krick@gmail.com> Co-authored-by: Georg Bremer <github@dschoordsch.de> Co-authored-by: Igor Lesnenko <igor.lesnenko@gmail.com> Co-authored-by: parabol-release-bot[bot] <150284312+parabol-release-bot[bot]@users.noreply.github.com> Co-authored-by: Matt Krick <matt.krick@gmail.com> Co-authored-by: Jordan Husney <jordan.husney@gmail.com> Co-authored-by: Nick O'Ferrall <nickoferrall@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #9340
GPT-3.5 turbo now has a large enough context window that it can accept the list of available templates.
I get similar results to GPT-4, and the response time is dramatically faster, so I think we should go with 3.5-turbo.
To test
aiTemplateorg feature flag