-
Notifications
You must be signed in to change notification settings - Fork 324
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: not all jira projects are displayed in the list if there are a lot of them #9422
Conversation
if (!networkOnly && filteredIntegrations.length === 0) { | ||
setNetworkOnly(true) | ||
setKeepParentFocus(false) | ||
setFirst((first) => first + 50) | ||
setFirst((first) => first + veryBigNumberOfRepositories) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 the correct solution would be to check the hasMore
field and fetch everything by increasing after
until we fetched all candidates. Only for the first fetch we should set networkOnly = true
as then the cached result on the server would be up to date already.
I think this solution is good enough for now, so let's not invest the additional work now.
* chore: Add more Atlassian logging (#9405) * chore: Add more Atlassian logging Mainly associate the logs with the traces so it's possible to check which GraphQL request caused a certain debug output. * Less code shuffling * Cleanup log directories Put them in the dev folder so they're out of sight. * fix: fix kudos in standups in nested lists (#9412) * Fix: fix kudos in standups in nested lists * fix test * chore(release): release v7.15.2 (#9414) Co-authored-by: parabol-release-bot[bot] <150284312+parabol-release-bot[bot]@users.noreply.github.com> * chore: update 3d secure card number in release_test.md (#9394) Previous 3d secure card number does not work anymore and I don't see it in the stripe docs https://stripe.com/docs/testing?testing-method=card-numbers#regulatory-cards * chore: bump node to v20.11.0 (#9410) Signed-off-by: Matt Krick <matt.krick@gmail.com> * chore: add embeddings table migration (#9372) * chore: add embeddings table migration * chore: code review changes * feat: auto-add pgvector extension in production Also: - fix: corrects types in standaloneMigrations.ts - fix: silly things I missed in the addEmbeddingTables migration * fix: check for POSTGRES_USE_PGVECTOR * fix: POSTGRES_USE_PGVECTOR strict check for === 'true' * feat: speed up ai search (#9421) * fix: not all jira projects are displayed in the list if there are a lot of them (#9422) * chore(release): release v7.16.0 (#9419) Co-authored-by: parabol-release-bot[bot] <150284312+parabol-release-bot[bot]@users.noreply.github.com> --------- Signed-off-by: Matt Krick <matt.krick@gmail.com> Co-authored-by: Georg Bremer <github@dschoordsch.de> Co-authored-by: Igor Lesnenko <igor.lesnenko@gmail.com> Co-authored-by: parabol-release-bot[bot] <150284312+parabol-release-bot[bot]@users.noreply.github.com> Co-authored-by: Matt Krick <matt.krick@gmail.com> Co-authored-by: Jordan Husney <jordan.husney@gmail.com> Co-authored-by: Nick O'Ferrall <nickoferrall@gmail.com>
Problem:
Quick solution:
Hot to test: