Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add team sections to the Custom category in activity library #9511

Merged
merged 2 commits into from
Mar 7, 2024

Conversation

Dschoordsch
Copy link
Contributor

Description

Sort

Demo

https://www.loom.com/share/e0930f718a774cceac08b98f2ccba26a?sid=f71a363f-5da1-4cc4-93ea-3ca97ea2c7ad

Testing scenarios

  • check all categories, especially "Quick Start" and "Retrospective"
  • "Custom" with no custom templates
  • custom templates on different teams
  • search
  • AI search

Final checklist

  • I checked the code review guidelines
  • I have added Metrics Representative as reviewer(s) if my PR invovles metrics/data/analytics related changes
  • I have performed a self-review of my code, the same way I'd do it for any other team member
  • I have tested all cases I listed in the testing scenarios and I haven't found any issues or regressions
  • Whenever I took a non-obvious choice I added a comment explaining why I did it this way
  • I added the label Skip Maintainer Review Indicating the PR only requires reviewer review and can be merged right after it's approved if the PR introduces only minor changes, does not contain any architectural changes or does not introduce any new patterns and I think one review is sufficient'
  • PR title is human readable and could be used in changelog

@github-actions github-actions bot added the size/m label Mar 6, 2024
@Dschoordsch Dschoordsch marked this pull request as ready for review March 7, 2024 11:07
Copy link
Contributor

@nickoferrall nickoferrall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works!

@nickoferrall nickoferrall merged commit 2338414 into master Mar 7, 2024
5 checks passed
@nickoferrall nickoferrall deleted the feat/addTeamSectionsInActivityLibrary branch March 7, 2024 14:00
@github-actions github-actions bot mentioned this pull request Mar 13, 2024
24 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants