Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Activity library illustrations in Firefox #9549

Merged
merged 2 commits into from Mar 19, 2024

Conversation

Dschoordsch
Copy link
Contributor

Description

Add the background image as an img tag. This way it's used to auto size.

Demo

image

Testing scenarios

  • check activity library on
    • Firefox
    • Chrome
    • Safari

Final checklist

  • I checked the code review guidelines
  • I have added Metrics Representative as reviewer(s) if my PR invovles metrics/data/analytics related changes
  • I have performed a self-review of my code, the same way I'd do it for any other team member
  • I have tested all cases I listed in the testing scenarios and I haven't found any issues or regressions
  • Whenever I took a non-obvious choice I added a comment explaining why I did it this way
  • I added the label Skip Maintainer Review Indicating the PR only requires reviewer review and can be merged right after it's approved if the PR introduces only minor changes, does not contain any architectural changes or does not introduce any new patterns and I think one review is sufficient'
  • PR title is human readable and could be used in changelog

@Dschoordsch Dschoordsch merged commit 00a1ca2 into master Mar 19, 2024
5 checks passed
@Dschoordsch Dschoordsch deleted the fix/activityLibraryOnFirefox branch March 19, 2024 17:02
@github-actions github-actions bot mentioned this pull request Mar 19, 2024
24 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants