Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(admin): fix an issue where ORG_ADMIN cannot see members from team they are not in #9560

Merged
merged 1 commit into from Mar 22, 2024

Conversation

tianrunhe
Copy link
Contributor

@tianrunhe tianrunhe commented Mar 22, 2024

Description

Fixes #9559

Testing scenarios

  • ORG_ADMIN can see team members
    • Promote yourself to ORG_ADMIN
    • Remove your super user role from your local PG
    • Go to an org teams page
    • Click into a team you are not in
    • You can see the team members and perform operations

Final checklist

  • I checked the code review guidelines
  • I have added Metrics Representative as reviewer(s) if my PR invovles metrics/data/analytics related changes
  • I have performed a self-review of my code, the same way I'd do it for any other team member
  • I have tested all cases I listed in the testing scenarios and I haven't found any issues or regressions
  • Whenever I took a non-obvious choice I added a comment explaining why I did it this way
  • I added the label Skip Maintainer Review Indicating the PR only requires reviewer review and can be merged right after it's approved if the PR introduces only minor changes, does not contain any architectural changes or does not introduce any new patterns and I think one review is sufficient'
  • PR title is human readable and could be used in changelog

@tianrunhe tianrunhe requested a review from jordanh March 22, 2024 18:04
@tianrunhe tianrunhe marked this pull request as ready for review March 22, 2024 18:04
@jordanh
Copy link
Contributor

jordanh commented Mar 22, 2024

Reviewed! @tianrunhe please merge when ready

Copy link
Contributor

@jordanh jordanh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😸

@tianrunhe tianrunhe merged commit ef0fbc2 into master Mar 22, 2024
8 checks passed
@tianrunhe tianrunhe deleted the bug/orgAdminSeesTeamMembers branch March 22, 2024 18:11
@github-actions github-actions bot mentioned this pull request Mar 27, 2024
24 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Org Admin cannot see users of teams
2 participants