Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: only query templates when a user clicks the options menu #9651

Merged
merged 3 commits into from May 7, 2024

Conversation

nickoferrall
Copy link
Contributor

Fix #9620

To test

  • Load a retro meeting and see that the templates are not queried by default
  • Click on the options menu in the Reflect stage and see that the templates are now queried

@nickoferrall
Copy link
Contributor Author

Hey @mattkrick, could you review this one please?

@mattkrick
Copy link
Member

Doesn't seem to work, video included to show how i tested: https://www.loom.com/share/fc18f08c50c441ee88e18f20ff99e154?sid=1bd925dc-3e67-4a14-926c-57391a23c502

Copy link
Member

@mattkrick mattkrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

still fires the query before opening

@nickoferrall
Copy link
Contributor Author

Thanks @mattkrick. That should be fixed now. Here's a quick Loom demo with the update: https://www.loom.com/share/1d448ddf057e40f29ff5e4e1eb211eef

@mattkrick
Copy link
Member

lookin good!

@mattkrick mattkrick merged commit 7c75eb1 into master May 7, 2024
5 checks passed
@mattkrick mattkrick deleted the fix/9620/retro-drawer-query branch May 7, 2024 15:54
@github-actions github-actions bot mentioned this pull request May 8, 2024
24 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RetroDrawer should query templates after we know a user wants a new one, not when the meeting loads
2 participants