Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(orgAdmin): org admin can promote others to org admin #9655

Merged
merged 3 commits into from Apr 23, 2024

Conversation

tianrunhe
Copy link
Contributor

@tianrunhe tianrunhe commented Apr 17, 2024

Description

Fixes #9642

Demo

2024-04-17 11 24 17

Testing scenarios

  • Org admin can promote/demote others to org admin
    • As a super user, run the GraphQL mutation setOrgUserRole(orgId: "xxx", userId: "yyy", role: ORG_ADMIN) to promote user A to org admin
    • Login as user A
    • Verify user A can then promote user B to org admin through the UI
    • Verify user A can demote user B from org admin role through the UI

Final checklist

  • I checked the code review guidelines
  • I have added Metrics Representative as reviewer(s) if my PR invovles metrics/data/analytics related changes
  • I have performed a self-review of my code, the same way I'd do it for any other team member
  • I have tested all cases I listed in the testing scenarios and I haven't found any issues or regressions
  • Whenever I took a non-obvious choice I added a comment explaining why I did it this way
  • I added the label Skip Maintainer Review Indicating the PR only requires reviewer review and can be merged right after it's approved if the PR introduces only minor changes, does not contain any architectural changes or does not introduce any new patterns and I think one review is sufficient'
  • PR title is human readable and could be used in changelog

@tianrunhe tianrunhe merged commit 01372bc into master Apr 23, 2024
5 checks passed
@tianrunhe tianrunhe deleted the feat/promoteToOA branch April 23, 2024 17:17
@github-actions github-actions bot mentioned this pull request Apr 25, 2024
24 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Org Admins cannot promote users to Org Admin or change Team Lead
2 participants