Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove premium badges from activity library cards #9669

Merged

Conversation

BartoszJarocki
Copy link
Contributor

@BartoszJarocki BartoszJarocki commented Apr 24, 2024

Description

Long time no see! This PR removes Premium badges from Activity Library as they're misleading

Demo

No demo

Testing scenarios

  • Check the empty state in activity library
  • Check if the newly created template doesn't have the Premium badge
  • Check if `Premoim

Final checklist

  • I checked the code review guidelines
  • I have added Metrics Representative as reviewer(s) if my PR invovles metrics/data/analytics related changes
  • I have performed a self-review of my code, the same way I'd do it for any other team member
  • I have tested all cases I listed in the testing scenarios and I haven't found any issues or regressions
  • Whenever I took a non-obvious choice I added a comment explaining why I did it this way
  • I added the label Skip Maintainer Review Indicating the PR only requires reviewer review and can be merged right after it's approved if the PR introduces only minor changes, does not contain any architectural changes or does not introduce any new patterns and I think one review is sufficient'
  • PR title is human readable and could be used in changelog

@github-actions github-actions bot requested a review from mattkrick April 24, 2024 16:21
@Dschoordsch Dschoordsch merged commit f3f0588 into ParabolInc:master Apr 25, 2024
6 checks passed
@github-actions github-actions bot mentioned this pull request Apr 25, 2024
24 tasks
@jordanh
Copy link
Contributor

jordanh commented Apr 29, 2024

Thank you SO much for this PR!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants