Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

go-kosu: ethereum snapshot block #270

Merged
merged 6 commits into from Sep 17, 2019
Merged

go-kosu: ethereum snapshot block #270

merged 6 commits into from Sep 17, 2019

Conversation

qustavo
Copy link
Contributor

@qustavo qustavo commented Sep 11, 2019

Introduce SnapshotBlock support into the Ethereum Witness and genesis block.

@qustavo qustavo added enhancement New feature or request go-kosu Project: go-kosu labels Sep 11, 2019
hrharder
hrharder reviewed Sep 11, 2019
View reviewed changes
Copy link
Member

@hrharder hrharder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, are we checking the following:

If initial_validator_info is set, there must be a snapshot_block

@L-Kov L-Kov requested review from L-Kov and removed request for L-Kov September 12, 2019 00:57
@qustavo qustavo force-pushed the feature/go-kosu/snapshot-block branch from 2b7abd2 to 68e7577 Compare September 17, 2019 11:47
@hrharder hrharder merged commit dfa6bfe into master Sep 17, 2019
@hrharder hrharder deleted the feature/go-kosu/snapshot-block branch September 17, 2019 19:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hrharder hrharder hrharder approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request go-kosu Project: go-kosu
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@qustavo @hrharder