error: redundant guard --> src/api/utils/pathdiff.rs:72:39 | 72 | (Some(_), Some(b)) if b == Component::ParentDir => return None, | ^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_guards help: try | 72 - (Some(_), Some(b)) if b == Component::ParentDir => return None, 72 + (Some(_), Some(Component::ParentDir)) => return None, |

error: redundant guard --> src/api/utils/pathdiff.rs:71:39 | 71 | (Some(a), Some(b)) if b == Component::CurDir => comps.push(a), | ^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_guards = note: `-D clippy::redundant-guards` implied by `-D clippy::all` = help: to override `-D clippy::all` add `#[allow(clippy::redundant_guards)]` help: try | 71 - (Some(a), Some(b)) if b == Component::CurDir => comps.push(a), 71 + (Some(a), Some(Component::CurDir)) => comps.push(a), |

error: using `clone` on type `HashFormat` which implements the `Copy` trait --> src/api/utils/hashing/mod.rs:58:24 | 58 | .map(|(k, v)| (k.clone(), v.clone())) | ^^^^^^^^^ help: try dereferencing it: `*k` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy = note: `-D clippy::clone-on-copy` implied by `-D clippy::all` = help: to override `-D clippy::all` add `#[allow(clippy::clone_on_copy)]`

error: methods called `into_*` usually take `self` by value --> src/api/sources/vanilla/mod.rs:20:22 | 20 | pub fn into_step(&self, ty: DownloadType) -> Option<Vec<Step>> { | ^^^^^ | = help: consider choosing a less ambiguous name = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention

error: useless conversion to the same type: `std::string::String` --> src/api/sources/url/mod.rs:25:14 | 25 | url: url.into(), | ^^^^^^^^^^ help: consider removing `.into()`: `url` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion = note: `-D clippy::useless-conversion` implied by `-D clippy::all` = help: to override `-D clippy::all` add `#[allow(clippy::useless_conversion)]`

error: question mark operator is useless here --> src/api/sources/modrinth/mod.rs:30:9 | 30 | Ok(self.fetch_all_versions(id).await?) | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing question mark and `Ok()`: `self.fetch_all_versions(id).await` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_question_mark

error: match expression looks like `matches!` macro --> src/api/models/server/server_flavor.rs:20:9 | 20 | / match self { 21 | | ServerFlavor::Modded => true, 22 | | _ => false, 23 | | } | |_________^ help: try: `matches!(self, ServerFlavor::Modded)` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_like_matches_macro

error: match expression looks like `matches!` macro --> src/api/models/server/server_flavor.rs:13:9 | 13 | / match self { 14 | | ServerFlavor::Proxy => false, 15 | | _ => true, 16 | | } | |_________^ help: try: `!matches!(self, ServerFlavor::Proxy)` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_like_matches_macro = note: `-D clippy::match-like-matches-macro` implied by `-D clippy::all` = help: to override `-D clippy::all` add `#[allow(clippy::match_like_matches_macro)]`

error: methods called `into_*` usually take `self` by value --> src/api/models/packwiz/mod.rs:35:29 | 35 | pub async fn into_addon(&self, app: &App, target: AddonTarget) -> Result<Addon> { | ^^^^^ | = help: consider choosing a less ambiguous name = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention

error: methods called `into_*` usually take `self` by value --> src/api/models/mrpack/mod.rs:28:29 | 28 | pub async fn into_addon(&self) -> Result<Addon> { | ^^^^^ | = help: consider choosing a less ambiguous name = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention

error: methods called `into_*` usually take `self` by value --> src/api/models/addon/addon_metadata.rs:15:21 | 15 | pub fn into_str(&self) -> &'static str { | ^^^^^ | = help: consider choosing a less ambiguous name = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention = note: `-D clippy::wrong-self-convention` implied by `-D clippy::all` = help: to override `-D clippy::all` add `#[allow(clippy::wrong_self_convention)]`

error: module has the same name as its containing module --> src/api/models/addon/mod.rs:1:1 | 1 | mod addon; | ^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception = note: `-D clippy::module-inception` implied by `-D clippy::all` = help: to override `-D clippy::all` add `#[allow(clippy::module_inception)]`

error: question mark operator is useless here --> src/api/models/modpack_source.rs:27:9 | 27 | Ok(Accessor::from(str)?) | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing question mark and `Ok()`: `Accessor::from(str)` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_question_mark = note: `-D clippy::needless-question-mark` implied by `-D clippy::all` = help: to override `-D clippy::all` add `#[allow(clippy::needless_question_mark)]`

error: this expression creates a reference which is immediately dereferenced by the compiler --> src/api/app/mod.rs:144:54 | 144 | addons.append(&mut source.resolve_addons(&self).await?); | ^^^^^ help: change this to: `self` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow

error: this expression creates a reference which is immediately dereferenced by the compiler --> src/api/app/mod.rs:76:24 | 76 | write_toml(&path, NETWORK_TOML, &*network)?; | ^^^^^ help: change this to: `path` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow

error: this expression creates a reference which is immediately dereferenced by the compiler --> src/api/app/mod.rs:71:24 | 71 | write_toml(&path, SERVER_TOML, &*server)?; | ^^^^^ help: change this to: `path` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow

error: this expression creates a reference which is immediately dereferenced by the compiler --> src/api/app/actions/build/mod.rs:13:41 | 13 | let steps = addon.resolve_steps(&self).await?; | ^^^^^ help: change this to: `self` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow = note: `-D clippy::needless-borrow` implied by `-D clippy::all` = help: to override `-D clippy::all` add `#[allow(clippy::needless_borrow)]`

error: lint group `pedantic` has the same priority (0) as a lint --> Cargo.toml:24:1 | 24 | pedantic = "warn" | ^^^^^^^^ ------ has an implicit priority of 0 25 | missing_docs_in_private_items = "allow" | ----------------------------- has the same priority as this lint | = note: the order of the lints in the table is ignored by Cargo = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#lint_groups_priority help: to have lints override the group set `pedantic` to a lower priority | 24 | pedantic = { level = "warn", priority = -1 } | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

error: lint group `all` has the same priority (0) as a lint --> Cargo.toml:23:1 | 23 | all = "deny" | ^^^ ------ has an implicit priority of 0 24 | pedantic = "warn" 25 | missing_docs_in_private_items = "allow" | ----------------------------- has the same priority as this lint | = note: the order of the lints in the table is ignored by Cargo = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#lint_groups_priority = note: `-D clippy::lint-groups-priority` implied by `-D clippy::all` = help: to override `-D clippy::all` add `#[allow(clippy::lint_groups_priority)]` help: to have lints override the group set `all` to a lower priority | 23 | all = { level = "deny", priority = -1 } | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

Clippy had exited with the 101 exit code

warning: unused `async` for function with no await statements --> src/api/utils/accessor.rs:35:5 | 35 | / pub async fn dir(&self) -> Result<Vec<String>> { 36 | | match self { 37 | | Accessor::ZipLocal(zip) => Ok(zip.file_names().map(ToOwned::to_owned).collect()), 38 | | Accessor::Local(path) => Ok(path ... | 44 | | } 45 | | } | |_____^ | = help: consider removing the `async` from this function = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_async

warning: unused `async` for function with no await statements --> src/api/models/packwiz/mod.rs:35:5 | 35 | / pub async fn into_addon(&self, app: &App, target: AddonTarget) -> Result<Addon> { 36 | | let addon_type = if let Some(update) = &self.update { 37 | | match update { 38 | | PackwizModUpdate::Modrinth { mod_id, version } => AddonType::Modrinth { ... | 64 | | Ok(addon) 65 | | } | |_____^ | = help: consider removing the `async` from this function = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_async

warning: unused `async` for function with no await statements --> src/api/models/mrpack/mod.rs:28:5 | 28 | / pub async fn into_addon(&self) -> Result<Addon> { 29 | | Ok(Addon { 30 | | environment: self.env.as_ref().map(|e| e.clone().into()), 31 | | addon_type: AddonType::Url { ... | 39 | | }) 40 | | } | |_____^ | = help: consider removing the `async` from this function = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_async

warning: unused `async` for function with no await statements --> src/api/app/actions/init/mod.rs:30:5 | 30 | / pub async fn init_network(&mut self) -> Result<()> { 31 | | intro("initializing network")?; 32 | | 33 | | let name: String = input("Name of the network?").interact()?; ... | 39 | | Ok(()) 40 | | } | |_____^ | = help: consider removing the `async` from this function = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_async

warning: unused `async` for function with no await statements --> src/api/app/actions/init/mod.rs:13:5 | 13 | / pub async fn init_server(&mut self) -> Result<()> { 14 | | intro("initializing server")?; 15 | | 16 | | let name: String = input("Name of the server?").interact()?; ... | 27 | | Ok(()) 28 | | } | |_____^ | = help: consider removing the `async` from this function = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_async

warning: unused `async` for function with no await statements --> src/api/app/actions/build/mod.rs:8:5 | 8 | / pub async fn action_install_jar(&self) -> Result<()> { 9 | | Ok(()) 10 | | } | |_____^ | = help: consider removing the `async` from this function = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_async = note: `-W clippy::unused-async` implied by `-W clippy::pedantic` = help: to override `-W clippy::pedantic` add `#[allow(clippy::unused_async)]`

warning: unnecessary `!=` operation --> src/api/utils/pathdiff.rs:51:5 | 51 | / if path.is_absolute() != base.is_absolute() { 52 | | if path.is_absolute() { 53 | | Some(PathBuf::from(path)) 54 | | } else { ... | 84 | | Some(comps.iter().map(|c| c.as_os_str()).collect()) 85 | | } | |_____^ | = help: change to `==` and swap the blocks of the `if`/`else` = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_not_else = note: `-W clippy::if-not-else` implied by `-W clippy::pedantic` = help: to override `-W clippy::pedantic` add `#[allow(clippy::if_not_else)]`

warning: usage of wildcard import --> src/api/utils/pathdiff.rs:23:5 | 23 | use std::path::*; | ^^^^^^^^^^^^ help: try: `std::path::{Component, Path, PathBuf}` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wildcard_imports

warning: you should put bare URLs between `<`/`>` or make a proper Markdown link --> src/api/utils/pathdiff.rs:1:5 | 1 | //! https://github.com/Manishearth/pathdiff | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_markdown

warning: this argument (1 byte) is passed by reference, but would be more efficient if passed by value (limit: 8 byte) --> src/api/utils/hashing/mod.rs:25:23 | 25 | pub fn get_digest(&self) -> Box<dyn DynDigest> { | ^^^^^ help: consider passing by value instead: `self` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref

warning: consider adding a `;` to the last statement for consistent formatting --> src/api/utils/hashing/curseforge.rs:24:9 | 24 | self.0 = Vec::new() | ^^^^^^^^^^^^^^^^^^^ help: add a `;` here: `self.0 = Vec::new();` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#semicolon_if_nothing_returned

warning: consider adding a `;` to the last statement for consistent formatting --> src/api/utils/hashing/curseforge.rs:14:9 | 14 | / self.0.extend( 15 | | data.iter() 16 | | .copied() 17 | | .filter(|&e| e != 9 && e != 10 && e != 13 && e != 32), 18 | | ) | |_________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#semicolon_if_nothing_returned = note: `-W clippy::semicolon-if-nothing-returned` implied by `-W clippy::pedantic` = help: to override `-W clippy::pedantic` add `#[allow(clippy::semicolon_if_nothing_returned)]` help: add a `;` here | 14 ~ self.0.extend( 15 + data.iter() 16 + .copied() 17 + .filter(|&e| e != 9 && e != 10 && e != 13 && e != 32), 18 + ); |

warning: redundant closure --> src/api/utils/accessor.rs:40:29 | 40 | .filter_map(|r| r.ok()) | ^^^^^^^^^^ help: replace the closure with the method itself: `std::result::Result::ok` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure_for_method_calls = note: `-W clippy::redundant-closure-for-method-calls` implied by `-W clippy::pedantic` = help: to override `-W clippy::pedantic` add `#[allow(clippy::redundant_closure_for_method_calls)]`

warning: case-sensitive file extension comparison --> src/api/utils/accessor.rs:26:19 | 26 | } else if str.ends_with(".zip") || str.ends_with(".mrpack") { | ^^^^^^^^^^^^^^^^^^^^^ | = help: consider using a case-insensitive comparison instead = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#case_sensitive_file_extension_comparisons = note: `-W clippy::case-sensitive-file-extension-comparisons` implied by `-W clippy::pedantic` = help: to override `-W clippy::pedantic` add `#[allow(clippy::case_sensitive_file_extension_comparisons)]` help: use std::path::Path | 26 ~ } else if std::path::Path::new(str) 27 + .extension() 28 ~ .map_or(false, |ext| ext.eq_ignore_ascii_case("zip")) || str.ends_with(".mrpack") { |

warning: wildcard matches only a single variant and will also match any future added variants --> src/api/sources/vanilla/mod.rs:57:13 | 57 | _ => bail!("You cant have both smh"), | ^ help: try: `Environment::Both` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_wildcard_for_single_variants = note: `-W clippy::match-wildcard-for-single-variants` implied by `-W clippy::pedantic` = help: to override `-W clippy::pedantic` add `#[allow(clippy::match_wildcard_for_single_variants)]`

warning: item in documentation is missing backticks --> src/api/sources/vanilla/version.rs:179:10 | 179 | /// (AssetIndex only) The size of the game version's assets | ^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_markdown help: try | 179 | /// (`AssetIndex` only) The size of the game version's assets | ~~~~~~~~~~~~

warning: item in documentation is missing backticks --> src/api/sources/vanilla/version.rs:177:10 | 177 | /// (AssetIndex only) The game version ID the assets are for | ^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_markdown help: try | 177 | /// (`AssetIndex` only) The game version ID the assets are for | ~~~~~~~~~~~~

warning: item in documentation is missing backticks --> src/api/sources/vanilla/version.rs:149:13 | 149 | /// The HashMap key specifies a classifier as additional information for downloading files | ^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_markdown = note: `-W clippy::doc-markdown` implied by `-W clippy::pedantic` = help: to override `-W clippy::pedantic` add `#[allow(clippy::doc_markdown)]` help: try | 149 | /// The `HashMap` key specifies a classifier as additional information for downloading files | ~~~~~~~~~

warning: possible intra-doc link using quotes instead of backticks --> src/api/sources/vanilla/version.rs:87:25 | 87 | /// "exclude": ["META-INF/"], | ^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_link_with_quotes = note: `-W clippy::doc-link-with-quotes` implied by `-W clippy::pedantic` = help: to override `-W clippy::pedantic` add `#[allow(clippy::doc_link_with_quotes)]`

warning: usage of wildcard import --> src/api/sources/github/mod.rs:14:5 | 14 | use models::*; | ^^^^^^^^^ help: try: `models::{GithubAsset, GithubRelease, GithubRepository}` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wildcard_imports

warning: usage of wildcard import --> src/api/models/server/server_type.rs:5:5 | 5 | utils::serde::*, | ^^^^^^^^^^^^^^^ help: try: `utils::serde::str_latest` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wildcard_imports = note: `-W clippy::wildcard-imports` implied by `-W clippy::pedantic` = help: to override `-W clippy::pedantic` add `#[allow(clippy::wildcard_imports)]`

warning: this match arm has an identical body to another arm --> src/api/models/server/server_flavor.rs:30:13 | 30 | ServerFlavor::Patched => true, | ---------------------^^^^^^^^ | | | help: try merging the arm patterns: `ServerFlavor::Patched | ServerFlavor::Proxy` | = help: or try changing either arm body note: other arm here --> src/api/models/server/server_flavor.rs:31:13 | 31 | ServerFlavor::Proxy => true, | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_same_arms

warning: this match arm has an identical body to another arm --> src/api/models/server/server_flavor.rs:29:13 | 29 | ServerFlavor::Modded => false, | --------------------^^^^^^^^^ | | | help: try merging the arm patterns: `ServerFlavor::Modded | ServerFlavor::Vanilla` | = help: or try changing either arm body note: other arm here --> src/api/models/server/server_flavor.rs:28:13 | 28 | ServerFlavor::Vanilla => false, | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_same_arms

warning: this argument (1 byte) is passed by reference, but would be more efficient if passed by value (limit: 8 byte) --> src/api/models/server/server_flavor.rs:26:29 | 26 | pub fn supports_plugins(&self) -> bool { | ^^^^^ help: consider passing by value instead: `self` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref

warning: this argument (1 byte) is passed by reference, but would be more efficient if passed by value (limit: 8 byte) --> src/api/models/server/server_flavor.rs:19:26 | 19 | pub fn supports_mods(&self) -> bool { | ^^^^^ help: consider passing by value instead: `self` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref

warning: this argument (1 byte) is passed by reference, but would be more efficient if passed by value (limit: 8 byte) --> src/api/models/server/server_flavor.rs:12:31 | 12 | pub fn supports_datapacks(&self) -> bool { | ^^^^^ help: consider passing by value instead: `self` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref

warning: called `map(<f>).unwrap_or(<a>)` on an `Option` value --> src/api/models/addon/addon_target.rs:37:14 | 37 | &Path::new(path) | ______________^ 38 | | .parent() 39 | | .map(|p| p.to_string_lossy().into_owned()) 40 | | .unwrap_or(".".to_owned()), | |__________________________________________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_unwrap_or = note: `-W clippy::map-unwrap-or` implied by `-W clippy::pedantic` = help: to override `-W clippy::pedantic` add `#[allow(clippy::map_unwrap_or)]` help: use `map_or(<a>, <f>)` instead | 39 - .map(|p| p.to_string_lossy().into_owned()) 39 + .map_or(".".to_owned(), |p| p.to_string_lossy().into_owned()), |

warning: this argument (1 byte) is passed by reference, but would be more efficient if passed by value (limit: 8 byte) --> src/api/models/addon/addon_metadata.rs:15:21 | 15 | pub fn into_str(&self) -> &'static str { | ^^^^^ help: consider passing by value instead: `self` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref = note: `-W clippy::trivially-copy-pass-by-ref` implied by `-W clippy::pedantic` = help: to override `-W clippy::pedantic` add `#[allow(clippy::trivially_copy_pass_by_ref)]`

warning: field name starts with the struct's name --> src/api/models/addon/addon.rs:12:5 | 12 | pub addon_type: AddonType, | ^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#struct_field_names = note: `-W clippy::struct-field-names` implied by `-W clippy::pedantic` = help: to override `-W clippy::pedantic` add `#[allow(clippy::struct_field_names)]`

warning: this match arm has an identical body to another arm --> src/api/models/modpack_source.rs:33:13 | 33 | Self::Remote { modpack_type, .. } => *modpack_type, | ---------------------------------^^^^^^^^^^^^^^^^^ | | | help: try merging the arm patterns: `Self::Remote { modpack_type, .. } | Self::Local { modpack_type, .. }` | = help: or try changing either arm body note: other arm here --> src/api/models/modpack_source.rs:32:13 | 32 | Self::Local { modpack_type, .. } => *modpack_type, | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_same_arms = note: `-W clippy::match-same-arms` implied by `-W clippy::pedantic` = help: to override `-W clippy::pedantic` add `#[allow(clippy::match_same_arms)]`

warning: method `diff_to` is never used --> src/api/utils/pathdiff.rs:4:8 | 3 | pub trait DiffTo { | ------ method in this trait 4 | fn diff_to<P>(&self, path: P) -> Option<PathBuf> | ^^^^^^^

warning: method `dir` is never used --> src/api/utils/accessor.rs:35:18 | 22 | impl Accessor { | ------------- method in this implementation ... 35 | pub async fn dir(&self) -> Result<Vec<String>> { | ^^^

warning: function `write_toml` is never used --> src/api/utils/mod.rs:35:8 | 35 | pub fn write_toml<T: Serialize>(path: &Path, filename: &str, value: &T) -> Result<()> { | ^^^^^^^^^^

warning: method `does_match` is never used --> src/api/step/mod.rs:30:12 | 29 | impl FileMeta { | ------------- method in this implementation 30 | pub fn does_match<P: AsRef<Path>>(&self, file: P) -> Result<bool> { | ^^^^^^^^^^

warning: function `dollar_repl` is never used --> src/api/sources/vanilla/rulematcher.rs:187:4 | 187 | fn dollar_repl<F>(input: &str, replacer: F) -> String | ^^^^^^^^^^^

warning: multiple associated items are never used --> src/api/sources/vanilla/rulematcher.rs:20:12 | 17 | impl PistonRuleMatcher { | ---------------------- associated items in this implementation ... 20 | pub fn new(os_name: String, os_arch: String, os_version: String) -> Self { | ^^^ ... 33 | pub fn empty() -> Self { | ^^^^^ ... 47 | pub fn from_os() -> Self { | ^^^^^^^ ... 71 | pub fn should_download_library(&self, library: &PistonLibrary) -> bool { | ^^^^^^^^^^^^^^^^^^^^^^^ ... 79 | pub fn get_native_library(&self, library: &PistonLibrary) -> Option<PistonFile> { | ^^^^^^^^^^^^^^^^^^ ... 93 | pub fn match_rules(&self, rules: &Vec<PistonRule>) -> bool { | ^^^^^^^^^^^ ... 107 | pub fn match_rule(&self, rule: &PistonRule) -> bool { | ^^^^^^^^^^ ... 117 | pub fn match_constraint(&self, constraint: &PistonRuleConstraints) -> bool { | ^^^^^^^^^^^^^^^^ ... 145 | pub fn build_args( | ^^^^^^^^^^ ... 172 | pub fn process_string(&self, map: &HashMap<String, String>, input: &str) -> String { | ^^^^^^^^^^^^^^

warning: struct `PistonRuleMatcher` is never constructed --> src/api/sources/vanilla/rulematcher.rs:12:12 | 12 | pub struct PistonRuleMatcher { | ^^^^^^^^^^^^^^^^^

warning: method `find` is never used --> src/api/sources/vanilla/manifest.rs:16:12 | 13 | impl VersionManifest { | -------------------- method in this implementation ... 16 | pub fn find(&self, id: &str) -> Option<VersionIndex> { | ^^^^

warning: constant `VERSION_MANIFEST_URL` is never used --> src/api/sources/vanilla/manifest.rs:3:11 | 3 | pub const VERSION_MANIFEST_URL: &str = | ^^^^^^^^^^^^^^^^^^^^

warning: methods `get_url` and `get_path` are never used --> src/api/sources/vanilla/assets.rs:21:12 | 18 | impl MCAsset { | ------------ methods in this implementation ... 21 | pub fn get_url(&self) -> String { | ^^^^^^^ ... 27 | pub fn get_path(&self) -> String { | ^^^^^^^^

warning: constant `RESOURCES_URL` is never used --> src/api/sources/vanilla/assets.rs:4:11 | 4 | pub const RESOURCES_URL: &str = "https://resources.download.minecraft.net"; | ^^^^^^^^^^^^^

warning: methods `fetch_manifest`, `fetch_latest_mcver`, and `resolve_steps` are never used --> src/api/sources/vanilla/mod.rs:45:18 | 44 | impl<'a> VanillaAPI<'a> { | ----------------------- methods in this implementation 45 | pub async fn fetch_manifest(&self) -> Result<VersionManifest> { | ^^^^^^^^^^^^^^ ... 49 | pub async fn fetch_latest_mcver(&self) -> Result<String> { | ^^^^^^^^^^^^^^^^^^ ... 53 | pub async fn resolve_steps(&self, version: &str, env: Environment) -> Result<Vec<Step>> { | ^^^^^^^^^^^^^

warning: struct `VanillaAPI` is never constructed --> src/api/sources/vanilla/mod.rs:42:12 | 42 | pub struct VanillaAPI<'a>(pub &'a App); | ^^^^^^^^^^

warning: method `into_step` is never used --> src/api/sources/vanilla/mod.rs:20:12 | 19 | impl VersionInfo { | ---------------- method in this implementation 20 | pub fn into_step(&self, ty: DownloadType) -> Option<Vec<Step>> { | ^^^^^^^^^

warning: methods `fetch_project`, `fetch_versions`, and `version_from_hash` are never used --> src/api/sources/modrinth/mod.rs:21:18 | 16 | impl<'a> ModrinthAPI<'a> { | ------------------------ methods in this implementation ... 21 | pub async fn fetch_project(&self, id: &str) -> Result<ModrinthProject> { | ^^^^^^^^^^^^^ ... 29 | pub async fn fetch_versions(&self, id: &str) -> Result<Vec<ModrinthVersion>> { | ^^^^^^^^^^^^^^ ... 83 | pub async fn version_from_hash(&self, hash: &str, algo: &str) -> Result<ModrinthVersion> { | ^^^^^^^^^^^^^^^^^

warning: method `fetch_repo_description` is never used --> src/api/sources/github/mod.rs:74:18 | 28 | impl<'a> GithubAPI<'a> { | ---------------------- method in this implementation ... 74 | pub async fn fetch_repo_description(&self, repo: &str) -> Result<String> { | ^^^^^^^^^^^^^^^^^^^^^^

warning: method `resolve_steps` is never used --> src/api/models/server/server_type.rs:82:18 | 81 | impl ServerJar { | -------------- method in this implementation 82 | pub async fn resolve_steps(&self, app: &App, env: Environment) -> Result<Vec<Step>> { | ^^^^^^^^^^^^^

warning: methods `supports_datapacks`, `supports_mods`, and `supports_plugins` are never used --> src/api/models/server/server_flavor.rs:12:12 | 11 | impl ServerFlavor { | ----------------- methods in this implementation 12 | pub fn supports_datapacks(&self) -> bool { | ^^^^^^^^^^^^^^^^^^ ... 19 | pub fn supports_mods(&self) -> bool { | ^^^^^^^^^^^^^ ... 26 | pub fn supports_plugins(&self) -> bool { | ^^^^^^^^^^^^^^^^

warning: struct `Lockfile` is never constructed --> src/api/models/lockfile/mod.rs:1:12 | 1 | pub struct Lockfile {} | ^^^^^^^^

warning: method `to_path` is never used --> src/api/models/addon/addon_target.rs:44:12 | 18 | impl AddonTarget { | ---------------- method in this implementation ... 44 | pub fn to_path(&self) -> PathBuf { | ^^^^^^^

warning: method `into_str` is never used --> src/api/models/addon/addon_metadata.rs:15:12 | 14 | impl AddonMetadataSource { | ------------------------ method in this implementation 15 | pub fn into_str(&self) -> &'static str { | ^^^^^^^^

warning: struct `AppOptions` is never constructed --> src/api/app/options/mod.rs:1:12 | 1 | pub struct AppOptions {} | ^^^^^^^^^^

warning: methods `init_server` and `init_network` are never used --> src/api/app/actions/init/mod.rs:13:18 | 12 | impl App { | -------- methods in this implementation 13 | pub async fn init_server(&mut self) -> Result<()> { | ^^^^^^^^^^^ ... 30 | pub async fn init_network(&mut self) -> Result<()> { | ^^^^^^^^^^^^

warning: method `action_install_jar` is never used --> src/api/app/actions/build/mod.rs:8:18 | 7 | impl App { | -------- method in this implementation 8 | pub async fn action_install_jar(&self) -> Result<()> { | ^^^^^^^^^^^^^^^^^^

warning: method `vanilla` is never used --> src/api/app/mod.rs:163:9 | 161 | impl App { | -------- method in this implementation 162 | api_methods! { 163 | vanilla => VanillaAPI, | ^^^^^^^ | = note: this warning originates in the macro `api_methods` (in Nightly builds, run with -Z macro-backtrace for more info)

warning: method `save_changes` is never used --> src/api/app/mod.rs:68:18 | 45 | impl App { | -------- method in this implementation ... 68 | pub async fn save_changes(&self) -> Result<()> { | ^^^^^^^^^^^^

warning: fields `server_path`, `network_path`, `network`, and `ci` are never read --> src/api/app/mod.rs:37:9 | 35 | pub struct App { | --- fields in this struct 36 | pub http_client: reqwest::Client, 37 | pub server_path: Option<PathBuf>, | ^^^^^^^^^^^ 38 | pub server: Option<Arc<RwLock<Server>>>, 39 | pub network_path: Option<PathBuf>, | ^^^^^^^^^^^^ 40 | pub network: Option<Arc<RwLock<Network>>>, | ^^^^^^^ 41 | pub cache: Cache, 42 | pub ci: bool, | ^^ | = note: `#[warn(dead_code)]` on by default

warning: unused variable: `hash` --> src/api/step/mod.rs:37:30 | 37 | if let Some((format, hash)) = get_best_hash(&self.hashes) {} | ^^^^ help: if this is intentional, prefix it with an underscore: `_hash`

warning: unused variable: `format` --> src/api/step/mod.rs:37:22 | 37 | if let Some((format, hash)) = get_best_hash(&self.hashes) {} | ^^^^^^ help: if this is intentional, prefix it with an underscore: `_format`

warning: unused import: `Digest` --> src/api/utils/hashing/curseforge.rs:1:14 | 1 | use digest::{Digest, DynDigest, FixedOutput, FixedOutputReset, OutputSizeUser, Reset, Update}; | ^^^^^^

warning: variable does not need to be mutable --> src/commands/sources/list.rs:8:18 | 8 | pub async fn run(mut app: App, args: Args) -> Result<()> { | ----^^^ | | | help: remove this `mut`

warning: unused variable: `args` --> src/commands/sources/list.rs:8:32 | 8 | pub async fn run(mut app: App, args: Args) -> Result<()> { | ^^^^ help: if this is intentional, prefix it with an underscore: `_args`

warning: variable does not need to be mutable --> src/commands/sources/mod.rs:12:18 | 12 | pub async fn run(mut app: App, args: Commands) -> Result<()> { | ----^^^ | | | help: remove this `mut`

warning: variable does not need to be mutable --> src/commands/init.rs:14:18 | 14 | pub async fn run(mut app: App, args: Args) -> Result<()> { | ----^^^ | | | help: remove this `mut`

warning: unused variable: `args` --> src/commands/init.rs:14:32 | 14 | pub async fn run(mut app: App, args: Args) -> Result<()> { | ^^^^ help: if this is intentional, prefix it with an underscore: `_args`

warning: unused variable: `inner` --> src/api/models/server/server_type.rs:92:34 | 92 | ServerType::Custom { inner } => todo!(), | ^^^^^ help: try ignoring the field: `inner: _`

warning: unused variable: `args` --> src/api/models/server/server_type.rs:91:48 | 91 | ServerType::BuildTools { software, args } => todo!(), | ^^^^ help: try ignoring the field: `args: _`

warning: unused variable: `software` --> src/api/models/server/server_type.rs:91:38 | 91 | ServerType::BuildTools { software, args } => todo!(), | ^^^^^^^^ help: try ignoring the field: `software: _`

warning: unused variable: `loader` --> src/api/models/server/server_type.rs:90:33 | 90 | ServerType::Forge { loader } => todo!(), | ^^^^^^ help: try ignoring the field: `loader: _`

warning: unused variable: `loader` --> src/api/models/server/server_type.rs:89:36 | 89 | ServerType::NeoForge { loader } => todo!(), | ^^^^^^ help: try ignoring the field: `loader: _`

warning: unused variable: `installer` --> src/api/models/server/server_type.rs:88:41 | 88 | ServerType::Quilt { loader, installer } => todo!(), | ^^^^^^^^^ help: try ignoring the field: `installer: _`

warning: unused variable: `loader` --> src/api/models/server/server_type.rs:88:33 | 88 | ServerType::Quilt { loader, installer } => todo!(), | ^^^^^^ help: try ignoring the field: `loader: _`

warning: unused variable: `installer` --> src/api/models/server/server_type.rs:87:42 | 87 | ServerType::Fabric { loader, installer } => todo!(), | ^^^^^^^^^ help: try ignoring the field: `installer: _`

warning: unused variable: `loader` --> src/api/models/server/server_type.rs:87:34 | 87 | ServerType::Fabric { loader, installer } => todo!(), | ^^^^^^ help: try ignoring the field: `loader: _`

warning: unused variable: `build` --> src/api/models/server/server_type.rs:86:34 | 86 | ServerType::Purpur { build } => todo!(), | ^^^^^ help: try ignoring the field: `build: _`

warning: unused variable: `build` --> src/api/models/server/server_type.rs:85:44 | 85 | ServerType::PaperMC { project, build } => todo!(), | ^^^^^ help: try ignoring the field: `build: _`

warning: unused variable: `project` --> src/api/models/server/server_type.rs:85:35 | 85 | ServerType::PaperMC { project, build } => todo!(), | ^^^^^^^ help: try ignoring the field: `project: _`

warning: variable does not need to be mutable --> src/api/app/actions/init/mod.rs:35:13 | 35 | let mut nw = Network { name }; | ----^^ | | | help: remove this `mut`

warning: variable does not need to be mutable --> src/api/app/actions/init/mod.rs:18:13 | 18 | let mut server = Server { | ----^^^^^^ | | | help: remove this `mut` | = note: `#[warn(unused_mut)]` on by default

warning: unused variable: `cache` --> src/api/app/step.rs:30:29 | 30 | if let Some(cache) = &metadata.cache {} | ^^^^^ help: if this is intentional, prefix it with an underscore: `_cache`

warning: unused variable: `app` --> src/api/sources/url/mod.rs:10:5 | 10 | app: &App, | ^^^ help: if this is intentional, prefix it with an underscore: `_app`

warning: unused variable: `filename` --> src/api/models/addon/addon.rs:26:71 | 26 | AddonType::MavenArtifact { url, group, artifact, version, filename } => todo!(), | ^^^^^^^^ help: try ignoring the field: `filename: _`

warning: unused variable: `version` --> src/api/models/addon/addon.rs:26:62 | 26 | AddonType::MavenArtifact { url, group, artifact, version, filename } => todo!(), | ^^^^^^^ help: try ignoring the field: `version: _`

warning: unused variable: `artifact` --> src/api/models/addon/addon.rs:26:52 | 26 | AddonType::MavenArtifact { url, group, artifact, version, filename } => todo!(), | ^^^^^^^^ help: try ignoring the field: `artifact: _`

warning: unused variable: `group` --> src/api/models/addon/addon.rs:26:45 | 26 | AddonType::MavenArtifact { url, group, artifact, version, filename } => todo!(), | ^^^^^ help: try ignoring the field: `group: _`

warning: unused variable: `url` --> src/api/models/addon/addon.rs:26:40 | 26 | AddonType::MavenArtifact { url, group, artifact, version, filename } => todo!(), | ^^^ help: try ignoring the field: `url: _`

warning: unused variable: `artifact` --> src/api/models/addon/addon.rs:25:51 | 25 | AddonType::Jenkins { url, job, build, artifact } => todo!(), | ^^^^^^^^ help: try ignoring the field: `artifact: _`

warning: unused variable: `build` --> src/api/models/addon/addon.rs:25:44 | 25 | AddonType::Jenkins { url, job, build, artifact } => todo!(), | ^^^^^ help: try ignoring the field: `build: _`

warning: unused variable: `job` --> src/api/models/addon/addon.rs:25:39 | 25 | AddonType::Jenkins { url, job, build, artifact } => todo!(), | ^^^ help: try ignoring the field: `job: _`

warning: unused variable: `url` --> src/api/models/addon/addon.rs:25:34 | 25 | AddonType::Jenkins { url, job, build, artifact } => todo!(), | ^^^ help: try ignoring the field: `url: _`

warning: unused variable: `version` --> src/api/models/addon/addon.rs:23:37 | 23 | AddonType::Hangar { id, version } => todo!(), | ^^^^^^^ help: try ignoring the field: `version: _`

warning: unused variable: `id` --> src/api/models/addon/addon.rs:23:33 | 23 | AddonType::Hangar { id, version } => todo!(), | ^^ help: try ignoring the field: `id: _`

warning: unused variable: `version` --> src/api/models/addon/addon.rs:22:37 | 22 | AddonType::Spigot { id, version } => todo!(), | ^^^^^^^ help: try ignoring the field: `version: _`

warning: unused variable: `id` --> src/api/models/addon/addon.rs:22:33 | 22 | AddonType::Spigot { id, version } => todo!(), | ^^ help: try ignoring the field: `id: _`

warning: unused variable: `version` --> src/api/models/addon/addon.rs:21:41 | 21 | AddonType::Curseforge { id, version } => todo!(), | ^^^^^^^ help: try ignoring the field: `version: _`

warning: unused variable: `id` --> src/api/models/addon/addon.rs:21:37 | 21 | AddonType::Curseforge { id, version } => todo!(), | ^^ help: try ignoring the field: `id: _`

warning: unused variable: `app` --> src/api/models/packwiz/mod.rs:35:36 | 35 | pub async fn into_addon(&self, app: &App, target: AddonTarget) -> Result<Addon> { | ^^^ help: if this is intentional, prefix it with an underscore: `_app`

warning: unused variable: `path` --> src/api/models/source.rs:29:30 | 29 | Source::Folder { path } => Ok(vec![]), | ^^^^ help: try ignoring the field: `path: _`

warning: unused variable: `path` --> src/api/models/source.rs:27:28 | 27 | Source::File { path } => Ok(vec![]), | ^^^^ help: try ignoring the field: `path: _` | = note: `#[warn(unused_variables)]` on by default

warning: binding's name is too similar to existing binding --> src/api/utils/pathdiff.rs:59:17 | 59 | let mut itb = base.components(); | ^^^ | note: existing binding defined here --> src/api/utils/pathdiff.rs:58:17 | 58 | let mut ita = path.components(); | ^^^ = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#similar_names

warning: unused import: `DynDigest` --> src/api/utils/hashing/curseforge.rs:1:22 | 1 | use digest::{Digest, DynDigest, FixedOutput, FixedOutputReset, OutputSizeUser, Reset, Update}; | ^^^^^^^^^

warning: unused imports: `Read`, `Seek` --> src/api/utils/accessor.rs:2:10 | 2 | io::{Read, Seek}, | ^^^^ ^^^^

warning: unused imports: `assets::*`, `rulematcher::*` --> src/api/sources/vanilla/mod.rs:17:16 | 17 | pub use self::{assets::*, manifest::*, rulematcher::*, version::*}; | ^^^^^^^^^ ^^^^^^^^^^^^^^

warning: unused import: `Context` --> src/api/sources/github/mod.rs:1:22 | 1 | use anyhow::{anyhow, Context, Result}; | ^^^^^^^

warning: unused import: `server_flavor::*` --> src/api/models/server/mod.rs:8:9 | 8 | pub use server_flavor::*; | ^^^^^^^^^^^^^^^^

warning: unused import: `std::path::Path` --> src/api/models/packwiz/mod.rs:4:5 | 4 | use std::path::Path; | ^^^^^^^^^^^^^^^

warning: unused import: `Environment` --> src/api/models/mrpack/mod.rs:13:44 | 13 | use super::{Addon, AddonTarget, AddonType, Environment}; | ^^^^^^^^^^^

warning: unused import: `models::Environment` --> src/api/models/mrpack/mrpack_file.rs:5:18 | 5 | use crate::api::{models::Environment, utils::hashing::HashFormat}; | ^^^^^^^^^^^^^^^^^^^

warning: unused import: `addon_metadata::*` --> src/api/models/addon/mod.rs:7:9 | 7 | pub use addon_metadata::*; | ^^^^^^^^^^^^^^^^^

warning: binding's name is too similar to existing binding --> src/api/app/mod.rs:91:13 | 91 | let res = req.send().await?.error_for_status()?; | ^^^ | note: existing binding defined here --> src/api/app/mod.rs:87:13 | 87 | let req = self.http_client.get(url.as_str()); | ^^^ = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#similar_names = note: `-W clippy::similar-names` implied by `-W clippy::pedantic` = help: to override `-W clippy::pedantic` add `#[allow(clippy::similar_names)]`

warning: unused imports: `CacheLocation`, `models::Addon` --> src/api/app/step.rs:7:5 | 7 | models::Addon, | ^^^^^^^^^^^^^ 8 | step::{CacheLocation, Step, StepResult}, | ^^^^^^^^^^^^^

warning: unused import: `init::*` --> src/api/app/actions/mod.rs:5:9 | 5 | pub use init::*; | ^^^^^^^

warning: unused import: `build::*` --> src/api/app/actions/mod.rs:4:9 | 4 | pub use build::*; | ^^^^^^^^ | = note: `#[warn(unused_imports)]` on by default

Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3, actions/upload-artifact@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.

Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3, actions-rs/clippy-check@v1. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.

The following actions uses node12 which is deprecated and will be forced to run on node16: actions-rs/clippy-check@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/

Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3, actions/upload-artifact@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.