Skip to content
Clippy and build

hot reload skeleton #13

Sign in to view logs

hot reload skeleton

hot reload skeleton #13

GitHub Actions / clippy failed Jun 21, 2023 in 0s

clippy

3 errors, 6 warnings

Details

Results

Message level Amount
Internal compiler error 0
Error 3
Warning 6
Note 0
Help 0

Versions

  • rustc 1.70.0 (90c541806 2023-05-31)
  • cargo 1.70.0 (ec8a8a0ca 2023-04-25)
  • clippy 0.1.70 (90c5418 2023-05-31)

Annotations

Check warning on line 224 in src/model/server.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

implicitly cloning a `String` by calling `to_owned` on its dereferenced type 

warning: implicitly cloning a `String` by calling `to_owned` on its dereferenced type
   --> src/model/server.rs:224:47
    |
224 |                 "mcver" | "mcversion" => Some(self.mc_version.to_owned()),
    |                                               ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using: `self.mc_version.clone()`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#implicit_clone

Check warning on line 141 in src/downloadable/import_url.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

implicitly cloning a `String` by calling `to_owned` on its dereferenced type 

warning: implicitly cloning a `String` by calling `to_owned` on its dereferenced type
   --> src/downloadable/import_url.rs:141:79
    |
141 |                         Ok(Self::Url { url: urlstr.to_owned(), filename: Some(input.to_owned()) })
    |                                                                               ^^^^^^^^^^^^^^^^ help: consider using: `input.clone()`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#implicit_clone
    = note: `#[warn(clippy::implicit_clone)]` implied by `#[warn(clippy::pedantic)]`

Check failure on line 141 in src/downloadable/import_url.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

redundant clone 

error: redundant clone
   --> src/downloadable/import_url.rs:141:84
    |
141 |                         Ok(Self::Url { url: urlstr.to_owned(), filename: Some(input.to_owned()) })
    |                                                                                    ^^^^^^^^^^^ help: remove this
    |
note: this value is dropped without further use
   --> src/downloadable/import_url.rs:141:79
    |
141 |                         Ok(Self::Url { url: urlstr.to_owned(), filename: Some(input.to_owned()) })
    |                                                                               ^^^^^
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_clone
    = note: `#[deny(clippy::redundant_clone)]` implied by `#[deny(clippy::all)]`

Check warning on line 183 in src/downloadable/import_url.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

this function has too many lines (143/100) 

warning: this function has too many lines (143/100)
   --> src/downloadable/import_url.rs:10:5
    |
10  | /     pub async fn from_url_interactive(
11  | |         client: &reqwest::Client,
12  | |         server: &Server,
13  | |         urlstr: &str,
...   |
182 | |         }
183 | |     }
    | |_____^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_lines
    = note: `#[warn(clippy::too_many_lines)]` implied by `#[warn(clippy::pedantic)]`

Check warning on line 50 in src/downloadable/sources/jenkins.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

item in documentation is missing backticks 

warning: item in documentation is missing backticks
  --> src/downloadable/sources/jenkins.rs:50:14
   |
50 | /// returns (build_url, fileName, relativePath)
   |              ^^^^^^^^^
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_markdown
   = note: `#[warn(clippy::doc_markdown)]` implied by `#[warn(clippy::pedantic)]`
help: try
   |
50 | /// returns (`build_url`, fileName, relativePath)
   |              ~~~~~~~~~~~

Check warning on line 16 in src/downloadable/sources/jenkins.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

called `.collect::<Vec<String>>().join("")` on an iterator 

warning: called `.collect::<Vec<String>>().join("")` on an iterator
  --> src/downloadable/sources/jenkins.rs:15:10
   |
15 |           .collect::<Vec<String>>()
   |  __________^
16 | |         .join("")
   | |_________________^ help: try using: `collect::<String>()`
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_join
note: the lint level is defined here
  --> src/main.rs:2:9
   |
2  | #![warn(clippy::pedantic)]
   |         ^^^^^^^^^^^^^^^^
   = note: `#[warn(clippy::unnecessary_join)]` implied by `#[warn(clippy::pedantic)]`

Check failure on line 127 in src/downloadable/sources/modrinth.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

using `.iter().next()` on an array 

error: using `.iter().next()` on an array
   --> src/downloadable/sources/modrinth.rs:127:21
    |
127 |         "latest" => project.iter().next(),
    |                     ^^^^^^^^^^^^^^^^^^^^^ help: try calling: `project.first()`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_next_slice

Check failure on line 81 in src/downloadable/sources/modrinth.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

using `.iter().next()` on an array 

error: using `.iter().next()` on an array
  --> src/downloadable/sources/modrinth.rs:81:21
   |
81 |         "latest" => project.iter().next(),
   |                     ^^^^^^^^^^^^^^^^^^^^^ help: try calling: `project.first()`
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_next_slice
note: the lint level is defined here
  --> src/main.rs:1:9
   |
1  | #![deny(clippy::all)]
   |         ^^^^^^^^^^^
   = note: `#[deny(clippy::iter_next_slice)]` implied by `#[deny(clippy::all)]`

Check warning on line 10 in src/downloadable/import_url.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

associated function `from_url_interactive` is never used 

warning: associated function `from_url_interactive` is never used
  --> src/downloadable/import_url.rs:10:18
   |
9  | impl Downloadable {
   | ----------------- associated function in this implementation
10 |     pub async fn from_url_interactive(
   |                  ^^^^^^^^^^^^^^^^^^^^
   |
   = note: `#[warn(dead_code)]` on by default
View more details on GitHub Actions